lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230413-rauchen-gesalzen-f15b4be69248@brauner> Date: Thu, 13 Apr 2023 11:54:20 +0200 From: Christian Brauner <brauner@...nel.org> To: "Ritesh Harjani (IBM)" <ritesh.list@...il.com> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@...radead.org>, "Darrick J . Wong" <djwong@...nel.org>, Ojaswin Mujoo <ojaswin@...ux.ibm.com>, Disha Goel <disgoel@...ux.ibm.com>, Christoph Hellwig <hch@....de> Subject: Re: [RFCv3 06/10] fs.h: Add TRACE_IOCB_STRINGS for use in trace points On Thu, Apr 13, 2023 at 02:10:28PM +0530, Ritesh Harjani (IBM) wrote: > Add TRACE_IOCB_STRINGS macro which can be used in the trace point patch to > print different flag values with meaningful string output. > > Tested-by: Disha Goel <disgoel@...ux.ibm.com> > Reviewed-by: Christoph Hellwig <hch@....de> > Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@...il.com> > --- Fine, but fs.h is such a dumping ground already I hope we can split more stuff out of it going forward... > include/linux/fs.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 9ca3813f43e2..6903fc15987a 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -340,6 +340,20 @@ enum rw_hint { > /* can use bio alloc cache */ > #define IOCB_ALLOC_CACHE (1 << 21) > > +/* for use in trace events */ > +#define TRACE_IOCB_STRINGS \ > + { IOCB_HIPRI, "HIPRI" }, \ > + { IOCB_DSYNC, "DSYNC" }, \ > + { IOCB_SYNC, "SYNC" }, \ > + { IOCB_NOWAIT, "NOWAIT" }, \ > + { IOCB_APPEND, "APPEND" }, \ > + { IOCB_EVENTFD, "EVENTD"}, \ s/EVENTD/EVENTFD/
Powered by blists - more mailing lists