lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20230413143530.GC360877@frogsfrogsfrogs> Date: Thu, 13 Apr 2023 07:35:30 -0700 From: "Darrick J. Wong" <djwong@...nel.org> To: "Ritesh Harjani (IBM)" <ritesh.list@...il.com> Cc: linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, Christoph Hellwig <hch@...radead.org>, Ojaswin Mujoo <ojaswin@...ux.ibm.com>, Disha Goel <disgoel@...ux.ibm.com> Subject: Re: [RFCv3 09/10] iomap: Minor refactor of iomap_dio_rw On Thu, Apr 13, 2023 at 02:10:31PM +0530, Ritesh Harjani (IBM) wrote: > The next patch brings in the tracepoint patch for iomap DIO functions. > This is a small refactor change for having a single out path. > > Tested-by: Disha Goel <disgoel@...ux.ibm.com> > Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@...il.com> IMHO this could've been part of the next patch instead of separate, but eh, whatever, looks good to me. Reviewed-by: Darrick J. Wong <djwong@...nel.org> --D > --- > fs/iomap/direct-io.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/fs/iomap/direct-io.c b/fs/iomap/direct-io.c > index 36ab1152dbea..5871956ee880 100644 > --- a/fs/iomap/direct-io.c > +++ b/fs/iomap/direct-io.c > @@ -679,11 +679,16 @@ iomap_dio_rw(struct kiocb *iocb, struct iov_iter *iter, > unsigned int dio_flags, void *private, size_t done_before) > { > struct iomap_dio *dio; > + ssize_t ret = 0; > > dio = __iomap_dio_rw(iocb, iter, ops, dops, dio_flags, private, > done_before); > - if (IS_ERR_OR_NULL(dio)) > - return PTR_ERR_OR_ZERO(dio); > - return iomap_dio_complete(dio); > + if (IS_ERR_OR_NULL(dio)) { > + ret = PTR_ERR_OR_ZERO(dio); > + goto out; > + } > + ret = iomap_dio_complete(dio); > +out: > + return ret; > } > EXPORT_SYMBOL_GPL(iomap_dio_rw); > -- > 2.39.2 >
Powered by blists - more mailing lists