linux-ext4 - Re: [RFCv1 1/4] ext4: kill unused function ext4_journalled_write_inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZDxNNjmopn0N5xof@casper.infradead.org>
Date:   Sun, 16 Apr 2023 20:32:06 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     "Ritesh Harjani (IBM)" <ritesh.list@...il.com>
Cc:     linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>,
        Ojaswin Mujoo <ojaswin@...ux.ibm.com>,
        Disha Goel <disgoel@...ux.ibm.com>
Subject: Re: [RFCv1 1/4] ext4: kill unused function
 ext4_journalled_write_inline_data

On Mon, Apr 17, 2023 at 12:01:50AM +0530, Ritesh Harjani (IBM) wrote:
> Commit 3f079114bf522 ("ext4: Convert data=journal writeback to use ext4_writepages()")
> Added support for writeback of journalled data into ext4_writepages()
> and killed function __ext4_journalled_writepage() which used to call
> ext4_journalled_write_inline_data() for inline data.
> This function got left over by mistake. Hence kill it's definition as
> no one uses it.
> 
> Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>