linux-ext4 - Re: [PATCH] ext4: remove unneeded check of nr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <168199842265.1078192.14715172373184437380.b4-ty@mit.edu>
Date:   Thu, 20 Apr 2023 09:47:09 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     adilger.kernel@...ger.ca, Tom Rix <trix@...hat.com>
Cc:     "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext4: remove unneeded check of nr_to_submit


On Thu, 16 Mar 2023 16:48:31 -0400, Tom Rix wrote:
> cppcheck reports
> fs/ext4/page-io.c:516:51: style:
>   Condition 'nr_to_submit' is always true [knownConditionTrueFalse]
>  if (fscrypt_inode_uses_fs_layer_crypto(inode) && nr_to_submit) {
>                                                   ^
> This earlier check to bail, makes this check unncessary
> 	/* Nothing to submit? Just unlock the page... */
> 	if (!nr_to_submit)
> 		return 0;
> 
> [...]

Applied, thanks!

[1/1] ext4: remove unneeded check of nr_to_submit
      commit: 8ae56b4e82ee29b5cc1fbea8b00a0a7e0758f3c2

Best regards,
-- 
Theodore Ts'o <tytso@....edu>