linux-ext4 - [syzbot] [ext4?] WARNING: bad unlock balance in unlock_two

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <00000000000028e2b905f9dd5f51@google.com>
Date:   Fri, 21 Apr 2023 12:07:43 -0700
From:   syzbot <syzbot+6c73bd34311ee489dbf5@...kaller.appspotmail.com>
To:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzkaller-bugs@...glegroups.com, tytso@....edu
Subject: [syzbot] [ext4?] WARNING: bad unlock balance in unlock_two_nondirectories

Hello,

syzbot found the following issue on:

HEAD commit:    cb0856346a60 Merge tag 'mm-hotfixes-stable-2023-04-19-16-3..
git tree:       upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=160d85b8280000
kernel config:  https://syzkaller.appspot.com/x/.config?x=11869c60f54496a7
dashboard link: https://syzkaller.appspot.com/bug?extid=6c73bd34311ee489dbf5
compiler:       gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2

Unfortunately, I don't have any reproducer for this issue yet.

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/03697c95ad2e/disk-cb085634.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/9e699bef459f/vmlinux-cb085634.xz
kernel image: https://storage.googleapis.com/syzbot-assets/1be3bc4b60fd/bzImage-cb085634.xz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+6c73bd34311ee489dbf5@...kaller.appspotmail.com

=====================================
WARNING: bad unlock balance detected!
6.3.0-rc7-syzkaller-00089-gcb0856346a60 #0 Not tainted
-------------------------------------
syz-executor.3/10999 is trying to release lock (&type->i_mutex_dir_key) at:
[<ffffffff81ea121d>] inode_unlock include/linux/fs.h:763 [inline]
[<ffffffff81ea121d>] unlock_two_nondirectories+0xbd/0x100 fs/inode.c:1138
but there are no more locks to release!

other info that might help us debug this:
1 lock held by syz-executor.3/10999:
 #0: ffff88803ff8a460 (sb_writers#4){.+.+}-{0:0}, at: __ext4_ioctl+0x10c9/0x4b00 fs/ext4/ioctl.c:1415

stack backtrace:
CPU: 1 PID: 10999 Comm: syz-executor.3 Not tainted 6.3.0-rc7-syzkaller-00089-gcb0856346a60 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106
 __lock_release kernel/locking/lockdep.c:5346 [inline]
 lock_release+0x4f1/0x670 kernel/locking/lockdep.c:5689
 up_write+0x2a/0x520 kernel/locking/rwsem.c:1625
 inode_unlock include/linux/fs.h:763 [inline]
 unlock_two_nondirectories+0xbd/0x100 fs/inode.c:1138
 swap_inode_boot_loader fs/ext4/ioctl.c:510 [inline]
 __ext4_ioctl+0x31d3/0x4b00 fs/ext4/ioctl.c:1418
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f9dc1a8c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9dc2726168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f9dc1babf80 RCX: 00007f9dc1a8c169
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000004
RBP: 00007f9dc1ae7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd35fd2d0f R14: 00007f9dc2726300 R15: 0000000000022000
 </TASK>
------------[ cut here ]------------
DEBUG_RWSEMS_WARN_ON((rwsem_owner(sem) != current) && !rwsem_test_oflags(sem, RWSEM_NONSPINNABLE)): count = 0x0, magic = 0xffff88803e77a1a8, owner = 0x0, curr 0xffff8880842f0000, list empty
WARNING: CPU: 1 PID: 10999 at kernel/locking/rwsem.c:1369 __up_write kernel/locking/rwsem.c:1369 [inline]
WARNING: CPU: 1 PID: 10999 at kernel/locking/rwsem.c:1369 up_write+0x425/0x520 kernel/locking/rwsem.c:1626
Modules linked in:
CPU: 1 PID: 10999 Comm: syz-executor.3 Not tainted 6.3.0-rc7-syzkaller-00089-gcb0856346a60 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023
RIP: 0010:__up_write kernel/locking/rwsem.c:1369 [inline]
RIP: 0010:up_write+0x425/0x520 kernel/locking/rwsem.c:1626
Code: 3c 02 00 0f 85 da 00 00 00 48 8b 55 00 4d 89 f1 53 4d 89 f8 4c 89 e9 48 c7 c6 a0 52 4c 8a 48 c7 c7 40 51 4c 8a e8 bb 22 e8 ff <0f> 0b 59 e9 dd fc ff ff 48 89 df e8 9b ca 70 00 e9 1a fc ff ff 48
RSP: 0018:ffffc900167afbd8 EFLAGS: 00010286
RAX: 0000000000000000 RBX: ffffffff8a4c5080 RCX: ffffc9000b5fa000
RDX: 0000000000040000 RSI: ffffffff814b6247 RDI: 0000000000000001
RBP: ffff88803e77a1a8 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 57525f4755424544 R12: ffff88803e77a1b0
R13: ffff88803e77a1a8 R14: ffff8880842f0000 R15: 0000000000000000
FS:  00007f9dc2726700(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000000c02174f2f8 CR3: 000000002b502000 CR4: 0000000000350ee0
Call Trace:
 <TASK>
 inode_unlock include/linux/fs.h:763 [inline]
 unlock_two_nondirectories+0xbd/0x100 fs/inode.c:1138
 swap_inode_boot_loader fs/ext4/ioctl.c:510 [inline]
 __ext4_ioctl+0x31d3/0x4b00 fs/ext4/ioctl.c:1418
 vfs_ioctl fs/ioctl.c:51 [inline]
 __do_sys_ioctl fs/ioctl.c:870 [inline]
 __se_sys_ioctl fs/ioctl.c:856 [inline]
 __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7f9dc1a8c169
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f9dc2726168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f9dc1babf80 RCX: 00007f9dc1a8c169
RDX: 0000000000000000 RSI: 0000000000006611 RDI: 0000000000000004
RBP: 00007f9dc1ae7ca1 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffd35fd2d0f R14: 00007f9dc2726300 R15: 0000000000022000
 </TASK>


---
This report is generated by a bot. It may contain errors.
See https://goo.gl/tpsmEJ for more information about syzbot.
syzbot engineers can be reached at syzkaller@...glegroups.com.

syzbot will keep track of this issue. See:
https://goo.gl/tpsmEJ#status for how to communicate with syzbot.