linux-ext4 - Re: [PATCH] fs/ext4/super.c : fix two compile errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <130cdccf-5bd6-bf67-4a2b-7f13fda0de3a@huawei.com>
Date:   Thu, 27 Apr 2023 09:32:02 +0800
From:   Jason Yan <yanaijie@...wei.com>
To:     Chris Clayton <chris2553@...glemail.com>,
        "tytso@....edu >> Theodore Y. Ts'o" <tytso@....edu>,
        <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] fs/ext4/super.c : fix two compile errors

On 2023/4/27 5:20, Chris Clayton wrote:
> dcbf87589d90 results in 2 build errors in fs/ext4/super.c because, in both affected
> functions, a variable is left unused if CONFIG_QUOTA is not defined. The patch
> below fixes this. It is compile tested only.
> 
> ...
>    CC      fs/ext4/super.o
> fs/ext4/super.c: In function 'ext4_put_super':
> fs/ext4/super.c:1262:13: error: unused variable 'i' [-Werror=unused-variable]
>   1262 |         int i, err;
>        |             ^
> fs/ext4/super.c: In function '__ext4_fill_super':
> fs/ext4/super.c:5200:22: error: unused variable 'i' [-Werror=unused-variable]
>   5200 |         unsigned int i;
>        |                      ^
> cc1: all warnings being treated as errors
> ...
> 
> Fixes:  dcbf87589d90 (ext4: factor out ext4_flex_groups_free())
> Signed-off-by: Chris Clayton<chris2553@...glemail.com>

There are already fixes. But still thank you for the patch.

http://patchwork.ozlabs.org/project/linux-ext4/patch/20230420-ext4-unused-variables-super-c-v1-1-138b6db6c21c@kernel.org/
http://patchwork.ozlabs.org/project/linux-ext4/patch/20230421070815.2260326-1-arnd@kernel.org/

Best wishes,
Jason