linux-ext4 - Re: Pick commit 2729cfdcfa ("ext4: use ext4_journal_start/stop for fast commit transactions")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230428144931.5wqpd5azweziee7u@quack3>
Date:   Fri, 28 Apr 2023 16:49:31 +0200
From:   Jan Kara <jack@...e.cz>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Jan Kara <jack@...e.cz>, stable@...r.kernel.org,
        Ted Tso <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: Pick commit 2729cfdcfa ("ext4: use ext4_journal_start/stop for
 fast commit transactions")

On Fri 28-04-23 14:02:46, Jan Kara wrote:
> On Fri 28-04-23 09:32:34, Greg KH wrote:
> > On Thu, Apr 27, 2023 at 06:24:59PM +0200, Jan Kara wrote:
> > > Hello,
> > > 
> > > recently I've debugged a deadlock issue in ext4 fast commit feature in our
> > > openSUSE Leap kernel. Checking with upstream I've found out the issue was
> > > accidentally fixed by commit 2729cfdcfa1c ("ext4: use
> > > ext4_journal_start/stop for fast commit transactions"). Can you please pick
> > > up this commit into the stable tree? The problem has been there since fast
> > > commit began to exist (in 5.10-rc1) so 5.10 and 5.15 stable trees need the
> > > fix. Thanks!
> > 
> > This commit does not apply to those branches, so how was it tested?
> 
> Hum, I've picked up the patch to our 5.14-based distro kernel and it
> applied (and passed testing) without issues so I was hoping 5.15 and 5.10
> would work as well. Apparently I was wrong. Sorry for the trouble.
> 
> > Can you send us backported, and tested, versions of this commit so that
> > we can apply them?
> 
> Yeah, I'll look into applying the patch directly to stable branches.

Tested version of the patch for 5.15-stable is attached.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR

View attachment "0001-ext4-use-ext4_journal_start-stop-for-fast-commit-tra.patch" of type "text/x-patch" (6672 bytes)