linux-ext4 - Re: WARNING in ext4_set_page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZE3030tKPvwU7fIc@mit.edu>
Date:   Sun, 30 Apr 2023 00:55:59 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     syzbot <syzbot+9a44753ac327c557796a@...kaller.appspotmail.com>
Cc:     adilger.kernel@...ger.ca, chris@...is-wilson.co.uk,
        dvyukov@...gle.com, jack@...e.cz, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, mika.kuoppala@...ux.intel.com,
        rodrigo.vivi@...el.com, syzkaller-bugs@...glegroups.com
Subject: Re: WARNING in ext4_set_page_dirty

#syz dup: WARNING in ext4_dirty_folio
#syz set subsystems: mm

ext4_set_page_dirty() was renamed to ext4_dirty_folio() in commit
e621900ad28b ("fs: Convert __set_page_dirty_buffers to
block_dirty_folio") in February 2022 --- which explains why it hasn't
reproduced in over 400 days,

(I assume marking it is the right thing to do, although the syzkaller
documentation doesn't explain exactly what happens after you mark the
report as a dup.  The other possibility would be to marking it as
invalid, to drop this as noise.  But that feels wrong, so I'm guessing
marking it as a dup is the best way to handle this kind of situation.)

I'm moving this to the mm subsystem, since the root cause is the
get_user_pages issue that has been with us for years, with discussions
as early as the 2018 LSF/MM.

					- Ted