linux-ext4 - Re: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c36ce5ee-5631-efaa-c502-a271ef106860@huaweicloud.com>
Date:   Fri, 12 May 2023 16:06:51 +0800
From:   Kemeng Shi <shikemeng@...weicloud.com>
To:     Ojaswin Mujoo <ojaswin@...ux.ibm.com>
Cc:     tytso@....edu, adilger.kernel@...ger.ca,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new_blocks



on 5/12/2023 2:39 PM, Ojaswin Mujoo wrote:
> On Mon, Apr 17, 2023 at 07:06:09PM +0800, Kemeng Shi wrote:
>> Function ext4_mb_new_blocks_simple needs count in cluster. Function
> 
> So there seems to be a typo in the commit header and commit message. I believe
> you mean ext4_mb_free_blocks() and ext4_mb_free_blocks_simple() ?
> Hi Ojaswin, thanks for review. Yes, it's a typo, I mean ext4_free_blocks and
ext4_mb_free_blocks_simple. I will fix the commit in next version.
> If that is the case, once corrected feel free to add:
> 
> Reviewed-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com>


-- 
Best wishes
Kemeng Shi