linux-ext4 - Re: [PATCH 6/5] ext4: Call fsverity_verify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <878rdn5uct.fsf@doe.com>
Date:   Wed, 17 May 2023 12:15:38 +0530
From:   Ritesh Harjani (IBM) <ritesh.list@...il.com>
To:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
        Ojaswin Mujoo <ojaswin@...ux.ibm.com>,
        Disha Goel <disgoel@...ux.ibm.com>
Cc:     "Matthew Wilcox (Oracle)" <willy@...radead.org>,
        Eric Biggers <ebiggers@...nel.org>
Subject: Re: [PATCH 6/5] ext4: Call fsverity_verify_folio()

"Matthew Wilcox (Oracle)" <willy@...radead.org> writes:

> Now that fsverity supports working on entire folios, call
> fsverity_verify_folio() instead of fsverity_verify_page()

Thanks for catching it.

>
> Reported-by: Eric Biggers <ebiggers@...nel.org>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> ---
>  fs/ext4/readpage.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I agree that we could use fsverity_verify_folio() instead of
fsverity_verify_page() here.

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>


>
> diff --git a/fs/ext4/readpage.c b/fs/ext4/readpage.c
> index 6f46823fba61..3e7d160f543f 100644
> --- a/fs/ext4/readpage.c
> +++ b/fs/ext4/readpage.c
> @@ -334,7 +334,7 @@ int ext4_mpage_readpages(struct inode *inode,
>  					  folio_size(folio));
>  			if (first_hole == 0) {
>  				if (ext4_need_verity(inode, folio->index) &&
> -				    !fsverity_verify_page(&folio->page))
> +				    !fsverity_verify_folio(folio))
>  					goto set_error_page;
>  				folio_mark_uptodate(folio);
>  				folio_unlock(folio);
> --
> 2.39.2