linux-ext4 - Re: mkfs.ext4 failed when orphan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230626180001.GA225716@mit.edu>
Date:   Mon, 26 Jun 2023 14:00:01 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     linux-ext4@...r.kernel.org
Subject: Re: mkfs.ext4 failed when orphan_file is enabled

On Mon, Jun 26, 2023 at 08:48:23PM +0800, Kemeng Shi wrote:
> Hi all, I find that "kvm-xfstests -c ext4/1k ext4/049" is failed on
> current dev branch because of mkfs.ext4 failure.

Hmm, I'm not seeing this mkfs.ext4 failure using 1.47.0.  I have two
cherry-picks on top of 1.47, but neither relate to mkfs.ext4:

  24a11cc371a4 ("e2fsck: Suppress "orphan file is clean" message in preen mode")

and

  8798bbb81687 ("e2fsck: fix handling of a invalid symlink in an inline_data directory")

See:

root@...-xfstests:~# /sbin/mkfs.ext4  -F  -b 4096 -g 8192 -N 1024 -I 4096 /dev/vdc
mke2fs 1.47.0 (5-Feb-2023)
/dev/vdc contains a ext4 file system
        last mounted on /vdc on Sun Jun 25 22:14:30 2023
Discarding device blocks: done                            
Creating filesystem with 1310720 4k blocks and 1280 inodes
Filesystem UUID: 127d490e-6caa-45cf-b5da-5616c5564a1a
Superblock backups stored on blocks: 
        8192, 24576, 40960, 57344, 73728, 204800, 221184, 401408, 663552, 
        1024000

Allocating group tables: done                            
Writing inode tables: done                            
Creating journal (16384 blocks): done
Writing superblocks and filesystem accounting information: done   

Can you confirm what version of e2fsprogs you are using?  Is it
exactly 1.47.0, or do you have some additional commits (either from
the upstream master or maint branches) applied?

> I also try this on my host machine with old version mke2fs. The orphan_file
> feature is not set in old version /etc/mke2fs.conf and the mkfs.ext4 works
> fine.
> 
> It's likely orphan_file is not supported by old version.

That's correct.

						- Ted