Message-ID: <c4eaff9389fe63ec4e29404ec0d1181b74935426.camel@kernel.org>
Date:   Mon, 10 Jul 2023 09:32:23 -0400
From:   Jeff Layton <jlayton@...nel.org>
To:     Christian Brauner <brauner@...nel.org>
Cc:     jk@...abs.org, arnd@...db.de, mpe@...erman.id.au,
        npiggin@...il.com, christophe.leroy@...roup.eu, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
        maco@...roid.com, joel@...lfernandes.org, cmllamas@...gle.com,
        surenb@...gle.com, dennis.dalessandro@...nelisnetworks.com,
        jgg@...pe.ca, leon@...nel.org, bwarrum@...ux.ibm.com,
        rituagar@...ux.ibm.com, ericvh@...nel.org, lucho@...kov.net,
        asmadeus@...ewreck.org, linux_oss@...debyte.com, dsterba@...e.com,
        dhowells@...hat.com, marc.dionne@...istor.com,
        viro@...iv.linux.org.uk, raven@...maw.net, luisbg@...nel.org,
        salah.triki@...il.com, aivazian.tigran@...il.com,
        ebiederm@...ssion.com, keescook@...omium.org, clm@...com,
        josef@...icpanda.com, xiubli@...hat.com, idryomov@...il.com,
        jaharkes@...cmu.edu, coda@...cmu.edu, jlbec@...lplan.org,
        hch@....de, nico@...xnic.net, rafael@...nel.org, code@...icks.com,
        ardb@...nel.org, xiang@...nel.org, chao@...nel.org,
        huyue2@...lpad.com, jefflexu@...ux.alibaba.com,
        linkinjeon@...nel.org, sj1557.seo@...sung.com, jack@...e.com,
        tytso@....edu, adilger.kernel@...ger.ca, jaegeuk@...nel.org,
        hirofumi@...l.parknet.co.jp, miklos@...redi.hu,
        rpeterso@...hat.com, agruenba@...hat.com, richard@....at,
        anton.ivanov@...bridgegreys.com, johannes@...solutions.net,
        mikulas@...ax.karlin.mff.cuni.cz, mike.kravetz@...cle.com,
        muchun.song@...ux.dev, dwmw2@...radead.org, shaggy@...nel.org,
        tj@...nel.org, trond.myklebust@...merspace.com, anna@...nel.org,
        chuck.lever@...cle.com, neilb@...e.de, kolga@...app.com,
        Dai.Ngo@...cle.com, tom@...pey.com, konishi.ryusuke@...il.com,
        anton@...era.com, almaz.alexandrovich@...agon-software.com,
        mark@...heh.com, joseph.qi@...ux.alibaba.com, me@...copeland.com,
        hubcap@...ibond.com, martin@...ibond.com, amir73il@...il.com,
        mcgrof@...nel.org, yzaikin@...gle.com, tony.luck@...el.com,
        gpiccoli@...lia.com, al@...rsen.net, sfrench@...ba.org,
        pc@...guebit.com, lsahlber@...hat.com, sprasad@...rosoft.com,
        senozhatsky@...omium.org, phillip@...ashfs.org.uk,
        rostedt@...dmis.org, mhiramat@...nel.org, dushistov@...l.ru,
        hdegoede@...hat.com, djwong@...nel.org, dlemoal@...nel.org,
        naohiro.aota@....com, jth@...nel.org, ast@...nel.org,
        daniel@...earbox.net, andrii@...nel.org, martin.lau@...ux.dev,
        song@...nel.org, yhs@...com, john.fastabend@...il.com,
        kpsingh@...nel.org, sdf@...gle.com, haoluo@...gle.com,
        jolsa@...nel.org, hughd@...gle.com, akpm@...ux-foundation.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, john.johansen@...onical.com,
        paul@...l-moore.com, jmorris@...ei.org, serge@...lyn.com,
        stephen.smalley.work@...il.com, eparis@...isplace.org,
        jgross@...e.com, stern@...land.harvard.edu, lrh2000@....edu.cn,
        sebastian.reichel@...labora.com, wsa+renesas@...g-engineering.com,
        quic_ugoswami@...cinc.com, quic_linyyuan@...cinc.com,
        john@...ping.me.uk, error27@...il.com, quic_uaggarwa@...cinc.com,
        hayama@...eo.co.jp, jomajm@...il.com, axboe@...nel.dk,
        dhavale@...gle.com, dchinner@...hat.com, hannes@...xchg.org,
        zhangpeng362@...wei.com, slava@...eyko.com, gargaditya08@...e.com,
        penguin-kernel@...ove.SAKURA.ne.jp, yifeliu@...stonybrook.edu,
        madkar@...stonybrook.edu, ezk@...stonybrook.edu,
        yuzhe@...china.com, willy@...radead.org, okanatov@...il.com,
        jeffxu@...omium.org, linux@...blig.org, mirimmad17@...il.com,
        yijiangshan@...inos.cn, yang.yang29@....com.cn,
        xu.xin16@....com.cn, chengzhihao1@...wei.com, shr@...kernel.io,
        Liam.Howlett@...cle.com, adobriyan@...il.com,
        chi.minghao@....com.cn, roberto.sassu@...wei.com,
        linuszeng@...cent.com, bvanassche@....org, zohar@...ux.ibm.com,
        yi.zhang@...wei.com, trix@...hat.com, fmdefrancesco@...il.com,
        ebiggers@...gle.com, princekumarmaurya06@...il.com,
        chenzhongjin@...wei.com, riel@...riel.com,
        shaozhengchao@...wei.com, jingyuwang_vip@....com,
        linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-usb@...r.kernel.org, v9fs@...ts.linux.dev,
        linux-fsdevel@...r.kernel.org, linux-afs@...ts.infradead.org,
        autofs@...r.kernel.org, linux-mm@...ck.org,
        linux-btrfs@...r.kernel.org, ceph-devel@...r.kernel.org,
        codalist@...a.cs.cmu.edu, ecryptfs@...r.kernel.org,
        linux-efi@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
        linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net,
        cluster-devel@...hat.com, linux-um@...ts.infradead.org,
        linux-mtd@...ts.infradead.org,
        jfs-discussion@...ts.sourceforge.net, linux-nfs@...r.kernel.org,
        linux-nilfs@...r.kernel.org, linux-ntfs-dev@...ts.sourceforge.net,
        ntfs3@...ts.linux.dev, ocfs2-devel@...ts.linux.dev,
        linux-karma-devel@...ts.sourceforge.net, devel@...ts.orangefs.org,
        linux-unionfs@...r.kernel.org, linux-hardening@...r.kernel.org,
        reiserfs-devel@...r.kernel.org, linux-cifs@...r.kernel.org,
        samba-technical@...ts.samba.org,
        linux-trace-kernel@...r.kernel.org, linux-xfs@...r.kernel.org,
        bpf@...r.kernel.org, netdev@...r.kernel.org,
        apparmor@...ts.ubuntu.com, linux-security-module@...r.kernel.org,
        selinux@...r.kernel.org
Subject: Re: [PATCH v2 00/89] fs: new accessors for inode->i_ctime

On Mon, 2023-07-10 at 14:35 +0200, Christian Brauner wrote:
> On Fri, Jul 07, 2023 at 08:42:31AM -0400, Jeff Layton wrote:
> > On Wed, 2023-07-05 at 14:58 -0400, Jeff Layton wrote:
> > > v2:
> > > - prepend patches to add missing ctime updates
> > > - add simple_rename_timestamp helper function
> > > - rename ctime accessor functions as inode_get_ctime/inode_set_ctime_*
> > > - drop individual inode_ctime_set_{sec,nsec} helpers
> > > 
> > 
> > After review by Jan and others, and Jan's ext4 rework, the diff on top
> > of the series I posted a couple of days ago is below. I don't really
> > want to spam everyone with another ~100 patch v3 series, but I can if
> > you think that's best.
> > 
> > Christian, what would you like me to do here?
> 
> I picked up the series from the list and folded the fixups you posted
> here into the respective fs conversion patches. I hope that helps you
> avoid a resend. You should have received a separate "thank you" mail for
> all of this.
> 
> To each patch that I folded one of the fixlets from below into I added a
> git note that records a link to your mail here and the respective patch
> hunk from this mail that I folded into the patch. git.kernel.org will
> show notes by default. For example,
> https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git/commit/?h=vfs.ctime&id=8b0e3c2e99004609a16ba145bcbdfdddb78e220e
> should show you the note I added. You can also fetch them via
> git fetch $remote refs/notes/*:refs/notes/*
> (You probably know that ofc but jic.) if you're interested.
> 
> Based on v6.5-rc1 as of today.
> 

Many thanks!!! I'll get to work rebasing the multigrain timestamp series
on top of that.

> Btw, both b4 and patchwork somehow treat the series in weird was.
> IOW, based on the message id of the cover letter I was able to pull most
> messages except for:
> 
> [07/92] fs: add ctime accessors infrastructure
> [08/92] fs: new helper: simple_rename_timestamp
> [92/92] fs: rename i_ctime field to __i_ctime
> 
> which I pulled in separately. Not sure what the cause of 
> 
> this is.

Good to know.

I ended up doing the send in two phases: one for the cover letter and
infrastructure patches that went to everyone, and one for the per-
subsystem patches that went do individual maintainers and lists.

I suspect that screwed up the message IDs somehow. Hopefully I won't
need to do a posting like that again soon, but I'll pay closer attention
to the message id handling next time.

Thanks again!
-- 
Jeff Layton <jlayton@...nel.org>

Powered by blists - more mailing lists