linux-ext4 - Re: [PATCH 00/10] A few fixes and cleanups to mballoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <87o7k5jm2b.fsf@doe.com>
Date:   Fri, 21 Jul 2023 21:25:56 +0530
From:   Ritesh Harjani (IBM) <ritesh.list@...il.com>
To:     Kemeng Shi <shikemeng@...weicloud.com>, tytso@....edu,
        adilger.kernel@...ger.ca, ojaswin@...ux.ibm.com,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     shikemeng@...weicloud.com
Subject: Re: [PATCH 00/10] A few fixes and cleanups to mballoc

Kemeng Shi <shikemeng@...weicloud.com> writes:

> Hi all, this series contains some random fixes and cleanups to mballoc
> which include correct grp validation, fix data overflow and so on.
> More details can be found in respective patches.
> Besides, 'kvm-xfstest smoke' runs successfully without error.

Thanks Kemeng for the cleanup series. Looks good to me with few minor
nits which I have commented in individual patches.

Note that I couldn't cleanly apply the series on ted's dev branch
(Patch-05 gave some minor conflict). Maybe you might have based your
changes on top of linux master or something. Anyways it was just a minor
conflict and I don't know what is Ted's general preference here, but I
thought of doing an FYI - 

-ritesh


>
> Thanks!
>
> Kemeng Shi (10):
>   ext4: correct grp validation in ext4_mb_good_group
>   ext4: avoid potential data overflow in next_linear_group
>   ext4: return found group directly in
>     ext4_mb_choose_next_group_p2_aligned
>   ext4: use is_power_of_2 helper in ext4_mb_regular_allocator
>   ext4: remove unnecessary return for void function
>   ext4: replace the traditional ternary conditional operator with with
>     max()/min()
>   ext4: remove unused ext4_{set}/{clear}_bit_atomic
>   ext4: return found group directly in
>     ext4_mb_choose_next_group_goal_fast
>   ext4: return found group directly in
>     ext4_mb_choose_next_group_best_avail
>   ext4: correct some stale comment of criteria
>
>  fs/ext4/ext4.h    |  2 --
>  fs/ext4/mballoc.c | 85 ++++++++++++++++++-----------------------------
>  2 files changed, 32 insertions(+), 55 deletions(-)
>
> -- 
> 2.30.0