linux-ext4 - Re: [PATCH] jbd2: Remove unused t_handle

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8138c559-325c-a4e3-1018-ca76ba185081@huawei.com>
Date:   Wed, 26 Jul 2023 19:19:45 +0800
From:   Zhang Yi <yi.zhang@...wei.com>
To:     Wang Jianjian <wangjianjian0@...mail.com>,
        <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] jbd2: Remove unused t_handle_lock

On 2023/7/24 22:58, Wang Jianjian wrote:
> Since commit 4f98186848('jbd2: refactor wait logic for transaction
> updates into a common function'), this lock has been no use.

Hi, I don't think the commit is correct, it should be
f7f497cb7024 ("jbd2: kill t_handle_lock transaction spinlock").

Thanks,
Yi.

> ---
>  include/linux/jbd2.h | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index d860499e15e4..8199235dbaf3 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -636,11 +636,6 @@ struct transaction_s
>  	 */
>  	struct list_head	t_inode_list;
>  
> -	/*
> -	 * Protects info related to handles
> -	 */
> -	spinlock_t		t_handle_lock;
> -
>  	/*
>  	 * Longest time some handle had to wait for running transaction
>  	 */
>