linux-ext4 - Re: [PATCH] e2fsck: Add percent to files and blocks feature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87wmyk4ity.fsf@gmail.com>
Date:   Fri, 28 Jul 2023 09:05:13 +0200
From:   Oscar Megia López <megia.oscar@...il.com>
To:     Markus Elfring <Markus.Elfring@....de>
Cc:     linux-ext4@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH] e2fsck: Add percent to files and blocks feature

Markus Elfring <Markus.Elfring@....de> writes:

> You should put also the address "linux-kernel@...r.kernel.org" into
> the message header field "Cc" (or "To").
>
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n231
>

Sorry, I though that were different proyects.

>
>> I need percentages to see how disk is occupied.
>
> At which occasions do you tend to care for such numbers?
>

For example, when the root disk is almost full, I'd rather know than get
system/application errors. It has happened to me and I think it is
necessary information.

>
>> If also I would see percentages for me would be perfect.
>
> Where would you find such information more helpful?
>

Because on my computer it shows busy/full for one or two seconds and
I don't have time to remember them, much less to calculate the occupancy
percentage. Humans handle percentages much better than many numbers in a
row (at least I do). Also when running e2fsck it is useful to see
percentages.

This is e2fsck with my patch:

$ sudo e2fsck/e2fsck /dev/sdc5
e2fsck 1.47.0 (5-Feb-2023)
label: clean, 405784/2449408 (16%) files, 6651303/9765625 (68%) blocks
$ 

I think it is helpful to show the percentage. Only number of
files/blocks and totals is not enought.

>
>> I think that this feature is going to be good for everyone.
>
> Will persuasion efforts grow accordingly?
>

Sorry, I don't understand what you mean.

>
> How do you think about to choose a corresponding imperative change suggestion?
>

Sorry I do not understand what you mean. If you want to say that my
sentence "I think that this feature is going to be good for everyone."
is to force the change, I'm sorry. It was just a comment to
explain why I submitted the patch. If it was only useful to me, I would
not have sent it.

> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.5-rc3#n94
>
> Regards,
> Markus

-- 
Regards
Oscar Megia López