linux-ext4 - Re: [PATCH 03/13] ext4: correct return value of ext4_convert_meta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230817135820.GX2247938@mit.edu>
Date:   Thu, 17 Aug 2023 09:58:20 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     Kemeng Shi <shikemeng@...weicloud.com>
Cc:     adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/13] ext4: correct return value of ext4_convert_meta_bg

On Thu, Aug 17, 2023 at 10:48:51AM +0800, Kemeng Shi wrote:
> 
> > errout:
> > 	ret = ext4_journal_stop(handle);
> > 	if (!err)
> > 		ret = err;
> > 	return ret;
> > 
> I think you mean:
> errout:
> 	ret = ext4_journal_stop(handle);
> 	if (*err*)
> 		ret = err;
> 	return ret;
> And I will fix in this way if I don't get wrong.

Yes, that's what I meant.  Another way of putting it might be:

	ret = ext4_journal_stop(handle);
	return (err ? err : ret);

				- Ted