lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20230818123232.2269-1-jack@suse.cz>
Date:   Wed, 23 Aug 2023 12:48:11 +0200
From:   Jan Kara <jack@...e.cz>
To:     Christian Brauner <brauner@...nel.org>
Cc:     Jens Axboe <axboe@...nel.dk>, <linux-fsdevel@...r.kernel.org>,
        <linux-block@...r.kernel.org>,
        Christoph Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>,
        Alasdair Kergon <agk@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Anna Schumaker <anna@...nel.org>, Chao Yu <chao@...nel.org>,
        Christian Borntraeger <borntraeger@...ux.ibm.com>,
        "Darrick J. Wong" <djwong@...nel.org>,
        Dave Kleikamp <shaggy@...nel.org>,
        David Sterba <dsterba@...e.com>, dm-devel@...hat.com,
        drbd-dev@...ts.linbit.com, Gao Xiang <xiang@...nel.org>,
        Jack Wang <jinpu.wang@...os.com>,
        Jaegeuk Kim <jaegeuk@...nel.org>,
        jfs-discussion@...ts.sourceforge.net,
        Joern Engel <joern@...ybastard.org>,
        Joseph Qi <joseph.qi@...ux.alibaba.com>,
        Kent Overstreet <kent.overstreet@...il.com>,
        linux-bcache@...r.kernel.org, linux-btrfs@...r.kernel.org,
        linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net, linux-mm@...ck.org,
        linux-mtd@...ts.infradead.org, linux-nfs@...r.kernel.org,
        linux-nilfs@...r.kernel.org, linux-nvme@...ts.infradead.org,
        linux-pm@...r.kernel.org, linux-raid@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
        linux-xfs@...r.kernel.org,
        "Md. Haris Iqbal" <haris.iqbal@...os.com>,
        Mike Snitzer <snitzer@...nel.org>,
        Minchan Kim <minchan@...nel.org>, ocfs2-devel@....oracle.com,
        reiserfs-devel@...r.kernel.org,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Song Liu <song@...nel.org>,
        Sven Schnelle <svens@...ux.ibm.com>,
        target-devel@...r.kernel.org, Ted Tso <tytso@....edu>,
        Trond Myklebust <trond.myklebust@...merspace.com>,
        xen-devel@...ts.xenproject.org
Subject: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle

Hello,

this is a v3 of the patch series which implements the idea of blkdev_get_by_*()
calls returning bdev_handle which is then passed to blkdev_put() [1]. This
makes the get and put calls for bdevs more obviously matching and allows us to
propagate context from get to put without having to modify all the users
(again!). In particular I need to propagate used open flags to blkdev_put() to
be able count writeable opens and add support for blocking writes to mounted
block devices. I'll send that series separately.

The series is based on Christian's vfs tree as of today as there is quite
some overlap. Patches have passed some reasonable testing - I've tested block
changes, md, dm, bcache, xfs, btrfs, ext4, swap. More testing or review is
always welcome. Thanks! I've pushed out the full branch to:

git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle

to ease review / testing. Since there were not many comments for v2 and
Christoph has acked the series I think we should start discussing how to merge
the series. Most collisions with this series seem to happen in the filesystems
area so VFS tree would seem as the least painful way to merge this. Jens,
are you OK with that?

Changes since v2:
* Rebased on top of current vfs tree
* Added some acks
* Reflected minor nits from Christoph
* Added missing conversion of blkdev_put() calls in cramfs and erofs
* Fixed possible leak of bdev handle in xfs if logdev is the same as fs dev

Changes since v1:
* Rebased on top of current vfs tree
* Renamed final functions to bdev_open_by_*() and bdev_release()
* Fixed detection of exclusive open in blkdev_ioctl() and blkdev_fallocate()
* Fixed swap conversion to properly reinitialize swap_info->bdev_handle
* Fixed xfs conversion to not oops with rtdev without logdev
* Couple other minor fixups

								Honza

[1] https://lore.kernel.org/all/ZJGNsVDhZx0Xgs2H@infradead.org

CC: Alasdair Kergon <agk@...hat.com>
CC: Andrew Morton <akpm@...ux-foundation.org>
CC: Anna Schumaker <anna@...nel.org>
CC: Chao Yu <chao@...nel.org>
CC: Christian Borntraeger <borntraeger@...ux.ibm.com>
CC: Coly Li <colyli@...e.de
CC: "Darrick J. Wong" <djwong@...nel.org>
CC: Dave Kleikamp <shaggy@...nel.org>
CC: David Sterba <dsterba@...e.com>
CC: dm-devel@...hat.com
CC: drbd-dev@...ts.linbit.com
CC: Gao Xiang <xiang@...nel.org>
CC: Jack Wang <jinpu.wang@...os.com>
CC: Jaegeuk Kim <jaegeuk@...nel.org>
CC: jfs-discussion@...ts.sourceforge.net
CC: Joern Engel <joern@...ybastard.org>
CC: Joseph Qi <joseph.qi@...ux.alibaba.com>
CC: Kent Overstreet <kent.overstreet@...il.com>
CC: linux-bcache@...r.kernel.org
CC: linux-btrfs@...r.kernel.org
CC: linux-erofs@...ts.ozlabs.org
CC: <linux-ext4@...r.kernel.org>
CC: linux-f2fs-devel@...ts.sourceforge.net
CC: linux-mm@...ck.org
CC: linux-mtd@...ts.infradead.org
CC: linux-nfs@...r.kernel.org
CC: linux-nilfs@...r.kernel.org
CC: linux-nvme@...ts.infradead.org
CC: linux-pm@...r.kernel.org
CC: linux-raid@...r.kernel.org
CC: linux-s390@...r.kernel.org
CC: linux-scsi@...r.kernel.org
CC: linux-xfs@...r.kernel.org
CC: "Md. Haris Iqbal" <haris.iqbal@...os.com>
CC: Mike Snitzer <snitzer@...nel.org>
CC: Minchan Kim <minchan@...nel.org>
CC: ocfs2-devel@....oracle.com
CC: reiserfs-devel@...r.kernel.org
CC: Sergey Senozhatsky <senozhatsky@...omium.org>
CC: Song Liu <song@...nel.org>
CC: Sven Schnelle <svens@...ux.ibm.com>
CC: target-devel@...r.kernel.org
CC: Ted Tso <tytso@....edu>
CC: Trond Myklebust <trond.myklebust@...merspace.com>
CC: xen-devel@...ts.xenproject.org

Previous versions:
Link: http://lore.kernel.org/r/20230629165206.383-1-jack@suse.cz # v1
Link: http://lore.kernel.org/r/20230810171429.31759-1-jack@suse.cz # v2

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ