linux-ext4 - Re: [PATCH] ext4: fix racy may inline data check in dio write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <169661554699.173366.13182900312377445374.b4-ty@mit.edu>
Date:   Fri,  6 Oct 2023 14:06:16 -0400
From:   "Theodore Ts'o" <tytso@....edu>
To:     linux-ext4@...r.kernel.org, Brian Foster <bfoster@...hat.com>
Cc:     "Theodore Ts'o" <tytso@....edu>
Subject: Re: [PATCH] ext4: fix racy may inline data check in dio write


On Mon, 02 Oct 2023 14:50:20 -0400, Brian Foster wrote:
> syzbot reports that the following warning from ext4_iomap_begin()
> triggers as of the commit referenced below:
> 
>         if (WARN_ON_ONCE(ext4_has_inline_data(inode)))
>                 return -ERANGE;
> 
> This occurs during a dio write, which is never expected to encounter
> an inode with inline data. To enforce this behavior,
> ext4_dio_write_iter() checks the current inline state of the inode
> and clears the MAY_INLINE_DATA state flag to either fall back to
> buffered writes, or enforce that any other writers in progress on
> the inode are not allowed to create inline data.
> 
> [...]

Applied, thanks!

[1/1] ext4: fix racy may inline data check in dio write
      commit: a37d4c46392e207518deb6533768986634b193c0

Best regards,
-- 
Theodore Ts'o <tytso@....edu>