lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Thu, 19 Oct 2023 13:57:19 +0200
From:   Jan Kara <>
To:     Baokun Li <>
Subject: Re: [PATCH 4/4] ext4: reduce unnecessary memory allocation in

On Wed 18-10-23 19:42:21, Baokun Li wrote:
> When a large flex_bg file system is resized, the number of groups to be
> added may be small, and a large amount of memory that will not be used will
> be allocated. Therefore, resize_bg can be set to the size after the number
> of new_group_data to be used is aligned upwards to the power of 2. This
> does not affect the disk layout after online resize and saves some memory.
> Signed-off-by: Baokun Li <>

Looks good, just one small comment below. Feel free to add:

Reviewed-by: Jan Kara <>

> @@ -248,6 +250,14 @@ static struct ext4_new_flex_group_data *alloc_flex_gd(unsigned int flexbg_size)
>  	else
>  		flex_gd->resize_bg = flexbg_size;
> +	/* Avoid allocating new groups that will not be used. */

Perhaps make the comment more understandable like:
	/* Avoid allocating large 'groups' array if not needed */

Jan Kara <>

Powered by blists - more mailing lists