linux-ext4 - Re: [PATCH] ext4: add __GFP_NOWARN to GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20231024075343.e5f0bd0d99962a4f0e32d1a0@linux-foundation.org>
Date:   Tue, 24 Oct 2023 07:53:43 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Jan Kara <jack@...e.cz>
Cc:     Hugh Dickins <hughd@...gle.com>,
        Matthew Wilcox <willy@...radead.org>,
        Hui Zhu <teawater@...group.com>, Theodore Ts'o <tytso@....edu>,
        linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org,
        linux-mm@...ck.org
Subject: Re: [PATCH] ext4: add __GFP_NOWARN to GFP_NOWAIT in readahead

On Tue, 24 Oct 2023 12:03:18 +0200 Jan Kara <jack@...e.cz> wrote:

> On Mon 23-10-23 23:26:08, Hugh Dickins wrote:
> > Since mm-hotfixes-stable commit e509ad4d77e6 ("ext4: use bdev_getblk() to
> > avoid memory reclaim in readahead path") rightly replaced GFP_NOFAIL
> > allocations by GFP_NOWAIT allocations, I've occasionally been seeing
> > "page allocation failure: order:0" warnings under load: all with
> > ext4_sb_breadahead_unmovable() in the stack.  I don't think those
> > warnings are of any interest: suppress them with __GFP_NOWARN.
> > 
> > Fixes: e509ad4d77e6 ("ext4: use bdev_getblk() to avoid memory reclaim in readahead path")
> > Signed-off-by: Hugh Dickins <hughd@...gle.com>
> 
> Yeah, makes sense. Just the commit you mention isn't upstream yet so I'm
> not sure whether the commit hash is stable.

e509ad4d77e6 is actually in mm-stable so yes, the hash should be stable.