lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Nov 2023 20:00:09 +0000 From: Matthew Wilcox <willy@...radead.org> To: "Ritesh Harjani (IBM)" <ritesh.list@...il.com> Cc: linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org Subject: Re: [RFC 2/3] ext2: Convert ext2 regular file buffered I/O to use iomap On Tue, Nov 21, 2023 at 12:35:20AM +0530, Ritesh Harjani (IBM) wrote: > +static void ext2_file_readahead(struct readahead_control *rac) > +{ > + return iomap_readahead(rac, &ext2_iomap_ops); We generally prefer to omit the 'return' when the function returns void (it's a GCC extension to not warn about it, so not actually a bug) This all looks marvellously simple. Good job!
Powered by blists - more mailing lists