lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Nov 2023 11:06:53 +0530 From: Ritesh Harjani (IBM) <ritesh.list@...il.com> To: Christoph Hellwig <hch@...radead.org> Cc: linux-ext4@...r.kernel.org, Jan Kara <jack@...e.cz>, linux-fsdevel@...r.kernel.org Subject: Re: [RFC 1/3] ext2: Fix ki_pos update for DIO buffered-io fallback case Christoph Hellwig <hch@...radead.org> writes: > On Tue, Nov 21, 2023 at 12:35:19AM +0530, Ritesh Harjani (IBM) wrote: >> Commit "filemap: update ki_pos in generic_perform_write", made updating >> of ki_pos into common code in generic_perform_write() function. >> This also causes generic/091 to fail. >> >> Fixes: 182c25e9c157 ("filemap: update ki_pos in generic_perform_write") > > Looks like this really was an in-flight collision with: > fb5de4358e1a ("ext2: Move direct-io to use iomap"). How did we manage > to not notice the failure for months, though? Yes, it was due to in-flight collision. I found it during this conversion and also noticed that generic/091 fails on upstream kernel. > > Otherwise looks good: > > Reviewed-by: Christoph Hellwig <hch@....de> Thanks! -ritesh
Powered by blists - more mailing lists