linux-ext4 - Re: [PATCH block/for-next v2 07/16] bcachefs: use new helper to get inode from block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20231127072409.y22jkynrchm4tkd2@moria.home.lan>
Date: Mon, 27 Nov 2023 02:24:09 -0500
From: Kent Overstreet <kent.overstreet@...ux.dev>
To: Damien Le Moal <dlemoal@...nel.org>
Cc: Yu Kuai <yukuai1@...weicloud.com>, hch@...radead.org,
	ming.lei@...hat.com, axboe@...nel.dk, roger.pau@...rix.com,
	colyli@...e.de, kent.overstreet@...il.com, joern@...ybastard.org,
	miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
	sth@...ux.ibm.com, hoeppner@...ux.ibm.com, hca@...ux.ibm.com,
	gor@...ux.ibm.com, agordeev@...ux.ibm.com, jejb@...ux.ibm.com,
	martin.petersen@...cle.com, clm@...com, josef@...icpanda.com,
	dsterba@...e.com, viro@...iv.linux.org.uk, brauner@...nel.org,
	nico@...xnic.net, xiang@...nel.org, chao@...nel.org, tytso@....edu,
	adilger.kernel@...ger.ca, agruenba@...hat.com, jack@...e.com,
	konishi.ryusuke@...il.com, dchinner@...hat.com,
	linux@...ssschuh.net, min15.li@...sung.com, yukuai3@...wei.com,
	willy@...radead.org, akpm@...ux-foundation.org, hare@...e.de,
	p.raghav@...sung.com, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
	linux-bcache@...r.kernel.org, linux-mtd@...ts.infradead.org,
	linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-bcachefs@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
	linux-ext4@...r.kernel.org, gfs2@...ts.linux.dev,
	linux-nilfs@...r.kernel.org, yi.zhang@...wei.com,
	yangerkun@...wei.com
Subject: Re: [PATCH block/for-next v2 07/16] bcachefs: use new helper to get
 inode from block_device

On Mon, Nov 27, 2023 at 04:09:47PM +0900, Damien Le Moal wrote:
> On 11/27/23 15:21, Yu Kuai wrote:
> > From: Yu Kuai <yukuai3@...wei.com>
> > 
> > Which is more efficiency, and also prepare to remove the field
> > 'bd_inode' from block_device.
> > 
> > Signed-off-by: Yu Kuai <yukuai3@...wei.com>
> > ---
> >  fs/bcachefs/util.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/fs/bcachefs/util.h b/fs/bcachefs/util.h
> > index 2984b57b2958..fe7ccb3a3517 100644
> > --- a/fs/bcachefs/util.h
> > +++ b/fs/bcachefs/util.h
> > @@ -518,7 +518,7 @@ int bch2_bio_alloc_pages(struct bio *, size_t, gfp_t);
> >  
> >  static inline sector_t bdev_sectors(struct block_device *bdev)
> >  {
> > -	return bdev->bd_inode->i_size >> 9;
> > +	return bdev_inode(bdev)->i_size >> 9;
> 
> shouldn't this use i_size_read() ?
> 
> I missed the history with this but why not use bdev_nr_sectors() and delete this
> helper ?

Actually, this helper seems to be dead code.