linux-ext4 - Re: [PATCH] lib/ext2fs: Validity checks for ext2fs_inode_scan_goto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231202171044.GB36164@frogsfrogsfrogs>
Date: Sat, 2 Dec 2023 09:10:44 -0800
From: "Darrick J. Wong" <djwong@...nel.org>
To: Brian Norris <briannorris@...omium.org>
Cc: Theodore Ts'o <tytso@....edu>, linux-ext4@...r.kernel.org
Subject: Re: [PATCH] lib/ext2fs: Validity checks for
 ext2fs_inode_scan_goto_blockgroup()

On Fri, Dec 01, 2023 at 09:30:38AM -0800, Brian Norris wrote:
> On Fri, Dec 1, 2023 at 8:24 AM Darrick J. Wong <djwong@...nel.org> wrote:
> > On Thu, Nov 30, 2023 at 04:01:18PM -0800, Brian Norris wrote:
> > > This resolves issues seen in ureadahead, when it uses an old packfile
> > > (with mismatching group indices) with a new filesystem.
> >
> > Say what now?  The boot time pre-caching thing Ubuntu used to have?
> > https://manpages.ubuntu.com/manpages/trusty/man8/ureadahead.8.html
> 
> Sure. ChromeOS still uses it. Steven Rostedt even bothered to do a
> talk about it recently:
> https://eoss2023.sched.com/event/1LcMw/the-resurrection-of-ureadahead-and-speeding-up-the-boot-process-and-preloading-applications-steven-rostedt-google

Wow.  I had no idea that ureadahead reads the inode blocks of a mounted
ext* filesystem into the page cache.  Welp, it's a good thing those are
part of the static layout.

Anyway, this fix looks correct to me, so I don't see any reason to hold
this up...
Reviewed-by: Darrick J. Wong <djwong@...nel.org>

--D

> 
> Brian
>