linux-ext4 - Re: [PATCH -next RFC 01/14] block: add some bdev apis

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZXC2Gg7NPWu9MULx@infradead.org>
Date: Wed, 6 Dec 2023 09:57:46 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Theodore Ts'o <tytso@....edu>
Cc: Christoph Hellwig <hch@...radead.org>,
	Yu Kuai <yukuai1@...weicloud.com>, axboe@...nel.dk,
	roger.pau@...rix.com, colyli@...e.de, kent.overstreet@...il.com,
	joern@...ybastard.org, miquel.raynal@...tlin.com, richard@....at,
	vigneshr@...com, sth@...ux.ibm.com, hoeppner@...ux.ibm.com,
	hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
	jejb@...ux.ibm.com, martin.petersen@...cle.com, clm@...com,
	josef@...icpanda.com, dsterba@...e.com, nico@...xnic.net,
	xiang@...nel.org, chao@...nel.org, adilger.kernel@...ger.ca,
	agruenba@...hat.com, jack@...e.com, konishi.ryusuke@...il.com,
	willy@...radead.org, akpm@...ux-foundation.org, hare@...e.de,
	p.raghav@...sung.com, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org,
	linux-bcache@...r.kernel.org, linux-mtd@...ts.infradead.org,
	linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-bcachefs@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org,
	gfs2@...ts.linux.dev, linux-nilfs@...r.kernel.org,
	yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH -next RFC 01/14] block: add some bdev apis

On Wed, Dec 06, 2023 at 12:50:38PM -0500, Theodore Ts'o wrote:
> This was added because pulling a mounted a USB thumb drive (or a HDD
> drops off the SATA bus) while the file system is mounted and actively
> in use, would result in a kernel OOPS.  If that's no longer true,
> that's great, but it would be good to test to make sure this is the
> case....

And, surprise, surprise - that didn't just affect ext4.  So I ended
up fixing this properly in the block layer.

> If we really want to remove it, I'd suggest doing this as a separate
> commit, so that after we see syzbot reports, or users complaining
> about kernel crashes, we can revert the removal if necessary.

Yes, this should of course be separate, well documented commit.