linux-ext4 - Re: [PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to read sb block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 12 Dec 2023 05:25:25 -0800
From: Christoph Hellwig <hch@...radead.org>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: axboe@...nel.dk, roger.pau@...rix.com, colyli@...e.de,
	kent.overstreet@...il.com, joern@...ybastard.org,
	miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
	sth@...ux.ibm.com, hoeppner@...ux.ibm.com, hca@...ux.ibm.com,
	gor@...ux.ibm.com, agordeev@...ux.ibm.com, jejb@...ux.ibm.com,
	martin.petersen@...cle.com, clm@...com, josef@...icpanda.com,
	dsterba@...e.com, viro@...iv.linux.org.uk, brauner@...nel.org,
	nico@...xnic.net, xiang@...nel.org, chao@...nel.org, tytso@....edu,
	adilger.kernel@...ger.ca, agruenba@...hat.com, jack@...e.com,
	konishi.ryusuke@...il.com, willy@...radead.org,
	akpm@...ux-foundation.org, p.raghav@...sung.com, hare@...e.de,
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	xen-devel@...ts.xenproject.org, linux-bcache@...r.kernel.org,
	linux-mtd@...ts.infradead.org, linux-s390@...r.kernel.org,
	linux-scsi@...r.kernel.org, linux-bcachefs@...r.kernel.org,
	linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org,
	gfs2@...ts.linux.dev, linux-nilfs@...r.kernel.org,
	yukuai3@...wei.com, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH RFC v2 for-6.8/block 15/18] buffer: add a new helper to
 read sb block

On Mon, Dec 11, 2023 at 10:07:53PM +0800, Yu Kuai wrote:
> +static __always_inline int buffer_uptodate_or_error(struct buffer_head *bh)
> +{
> +	/*
> +	 * If the buffer has the write error flag, data was failed to write
> +	 * out in the block. In this case, set buffer uptodate to prevent
> +	 * reading old data.
> +	 */
> +	if (buffer_write_io_error(bh))
> +		set_buffer_uptodate(bh);
> +	return buffer_uptodate(bh);
> +}

So - risking this blows up into a lot of nasty work: Why do we even
clear the uptodate flag on write errors?  Doing so makes not sense to
me as the data isn't any less uptodate just because we failed to write
it..