linux-ext4 - Re: [PATCH 0/5] jbd2: Add errseq to detect writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231212143943.ycy35sujw3e5cz5k@quack3>
Date: Tue, 12 Dec 2023 15:39:43 +0100
From: Jan Kara <jack@...e.cz>
To: Zhihao Cheng <chengzhihao1@...wei.com>
Cc: tytso@....edu, jack@...e.com, linux-ext4@...r.kernel.org,
	yi.zhang@...wei.com
Subject: Re: [PATCH 0/5] jbd2: Add errseq to detect writeback

On Fri 03-11-23 22:52:45, Zhihao Cheng wrote:
> According to discussions in [1], this patchset adds errseq in journal to
> enable JDB2 detecting meatadata writeback error of fs dev. Then, orginal
> checking mechanism could be removed.
> 
> [1] https://lore.kernel.org/all/20230908124317.2955345-1-chengzhihao1@huawei.com/T/

Thanks for the series! I'm sorry for the very delayed review. There has
been a lot of work, conference and other stuff happening lately... Anyway
the series looks good, I had just some language corrections.

								Honza

> 
> Zhihao Cheng (5):
>   jbd2: Add errseq to detect client fs's bdev writeback error
>   jbd2: Replace journal state flag by checking errseq
>   jbd2: Remove unused 'JBD2_CHECKPOINT_IO_ERROR' and 'j_atomic_flags'
>   jbd2: Abort journal when detecting metadata writeback error of fs dev
>   ext4: Move ext4_check_bdev_write_error() into nojournal mode
> 
>  fs/ext4/ext4_jbd2.c   |  5 ++---
>  fs/jbd2/checkpoint.c  | 11 -----------
>  fs/jbd2/journal.c     | 11 ++++++-----
>  fs/jbd2/recovery.c    |  7 +------
>  fs/jbd2/transaction.c | 14 ++++++++++++++
>  include/linux/jbd2.h  | 37 ++++++++++++++++++++++++++-----------
>  6 files changed, 49 insertions(+), 36 deletions(-)
> 
> -- 
> 2.39.2
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR