linux-ext4 - Re: [PATCH 4/9] hfs: remove ->writepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20231215045943.GA16040@lst.de>
Date: Fri, 15 Dec 2023 05:59:43 +0100
From: Christoph Hellwig <hch@....de>
To: Matthew Wilcox <willy@...radead.org>
Cc: Christoph Hellwig <hch@....de>, Namjae Jeon <linkinjeon@...nel.org>,
	Sungjong Seo <sj1557.seo@...sung.com>, Jan Kara <jack@...e.com>,
	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
	Mikulas Patocka <mikulas@...ax.karlin.mff.cuni.cz>,
	Dave Kleikamp <shaggy@...nel.org>,
	Bob Copeland <me@...copeland.com>, linux-fsdevel@...r.kernel.org,
	linux-ext4@...r.kernel.org, jfs-discussion@...ts.sourceforge.net,
	linux-karma-devel@...ts.sourceforge.net, linux-mm@...ck.org
Subject: Re: [PATCH 4/9] hfs: remove ->writepage

On Thu, Dec 14, 2023 at 07:01:25PM +0000, Matthew Wilcox wrote:
> Was there a reason you only did this for hfs_aops and not for
> hfs_btree_aops?  It feels like anything that just calls
> block_write_full_page() in the writepage handler should be converted
> to just calling mpage_writepages() in the writepages handler.
> I have a few of those conversions done, but obviously they're in
> filesystems that are basically untestable.

Probably.  I remember I had a good reason to skip, and the lack of
testability might have been it.  Note that for hfsplus in particular
we should actually be able to test now that the port of the hfs
userspace has returned to distros.  I haven't actually gotten to
see what the test baseline looks like, though.