lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240102130554.dawoitclnhxmrrfs@quack3> Date: Tue, 2 Jan 2024 14:05:54 +0100 From: Jan Kara <jack@...e.cz> To: Kemeng Shi <shikemeng@...weicloud.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 6/8] ext4: remove unused return value of ext4_mb_release_inode_pa On Sun 26-11-23 00:11:41, Kemeng Shi wrote: > Remove unused return value of ext4_mb_release_inode_pa > > Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/mballoc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c > index 8d6246db3..1ed6d1d5a 100644 > --- a/fs/ext4/mballoc.c > +++ b/fs/ext4/mballoc.c > @@ -5278,7 +5278,7 @@ static void ext4_mb_new_preallocation(struct ext4_allocation_context *ac) > * the caller MUST hold group/inode locks. > * TODO: optimize the case when there are no in-core structures yet > */ > -static noinline_for_stack int > +static noinline_for_stack void > ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh, > struct ext4_prealloc_space *pa) > { > @@ -5328,8 +5328,6 @@ ext4_mb_release_inode_pa(struct ext4_buddy *e4b, struct buffer_head *bitmap_bh, > */ > } > atomic_add(free, &sbi->s_mb_discarded); > - > - return 0; > } > > static noinline_for_stack int > -- > 2.30.0 > > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists