lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240103110417.6del4dd3ulraikcz@quack3> Date: Wed, 3 Jan 2024 12:04:17 +0100 From: Jan Kara <jack@...e.cz> To: Zhang Yi <yi.zhang@...weicloud.com> Cc: linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com, hch@...radead.org, djwong@...nel.org, willy@...radead.org, yi.zhang@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com, wangkefeng.wang@...wei.com Subject: Re: [RFC PATCH v2 04/25] ext4: add a hole extent entry in cache after punch On Tue 02-01-24 20:38:57, Zhang Yi wrote: > From: Zhang Yi <yi.zhang@...wei.com> > > In order to cache hole extents in the extent status tree and keep the > hole length as long as possible, re-add a hole entry to the cache just > after punching a hole. > > Signed-off-by: Zhang Yi <yi.zhang@...wei.com> Looks good. Feel free to add: Reviewed-by: Jan Kara <jack@...e.cz> Honza > --- > fs/ext4/inode.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index 142c67f5c7fc..1b5e6409f958 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -4000,12 +4000,12 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) > > /* If there are blocks to remove, do it */ > if (stop_block > first_block) { > + ext4_lblk_t hole_len = stop_block - first_block; > > down_write(&EXT4_I(inode)->i_data_sem); > ext4_discard_preallocations(inode, 0); > > - ext4_es_remove_extent(inode, first_block, > - stop_block - first_block); > + ext4_es_remove_extent(inode, first_block, hole_len); > > if (ext4_test_inode_flag(inode, EXT4_INODE_EXTENTS)) > ret = ext4_ext_remove_space(inode, first_block, > @@ -4014,6 +4014,8 @@ int ext4_punch_hole(struct file *file, loff_t offset, loff_t length) > ret = ext4_ind_remove_space(handle, inode, first_block, > stop_block); > > + ext4_es_insert_extent(inode, first_block, hole_len, ~0, > + EXTENT_STATUS_HOLE); > up_write(&EXT4_I(inode)->i_data_sem); > } > ext4_fc_track_range(handle, inode, first_block, stop_block); > -- > 2.39.2 > -- Jan Kara <jack@...e.com> SUSE Labs, CR
Powered by blists - more mailing lists