lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <29bfcfc7-62b0-3876-78ce-f7ebe3506eb6@huaweicloud.com> Date: Thu, 4 Jan 2024 20:19:05 +0800 From: Yu Kuai <yukuai1@...weicloud.com> To: Jan Kara <jack@...e.cz>, Yu Kuai <yukuai1@...weicloud.com> Cc: axboe@...nel.dk, roger.pau@...rix.com, colyli@...e.de, kent.overstreet@...il.com, joern@...ybastard.org, miquel.raynal@...tlin.com, richard@....at, vigneshr@...com, sth@...ux.ibm.com, hoeppner@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, clm@...com, josef@...icpanda.com, dsterba@...e.com, viro@...iv.linux.org.uk, brauner@...nel.org, nico@...xnic.net, xiang@...nel.org, chao@...nel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.com, konishi.ryusuke@...il.com, willy@...radead.org, akpm@...ux-foundation.org, hare@...e.de, p.raghav@...sung.com, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org, linux-bcache@...r.kernel.org, linux-mtd@...ts.infradead.org, linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org, linux-bcachefs@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org, linux-nilfs@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com> Subject: Re: [PATCH RFC v3 for-6.8/block 02/17] xen/blkback: use bdev api in xen_update_blkif_status() Hi, Jan! 在 2024/01/04 19:06, Jan Kara 写道: > On Thu 21-12-23 16:56:57, Yu Kuai wrote: >> From: Yu Kuai <yukuai3@...wei.com> >> >> Avoid to access bd_inode directly, prepare to remove bd_inode from >> block_devcie. >> >> Signed-off-by: Yu Kuai <yukuai3@...wei.com> >> --- >> drivers/block/xen-blkback/xenbus.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c >> index e34219ea2b05..e645afa4af57 100644 >> --- a/drivers/block/xen-blkback/xenbus.c >> +++ b/drivers/block/xen-blkback/xenbus.c >> @@ -104,8 +104,7 @@ static void xen_update_blkif_status(struct xen_blkif *blkif) >> xenbus_dev_error(blkif->be->dev, err, "block flush"); >> return; >> } >> - invalidate_inode_pages2( >> - blkif->vbd.bdev_handle->bdev->bd_inode->i_mapping); >> + invalidate_bdev(blkif->vbd.bdev_handle->bdev); > > This function uses invalidate_inode_pages2() while invalidate_bdev() ends > up using mapping_try_invalidate() and there are subtle behavioral > differences between these two (for example invalidate_inode_pages2() tries > to clean dirty pages using the ->launder_folio method). So I think you'll > need helper like invalidate_bdev2() for this. Thanks for reviewing this patch, I know the differenct between then, what I don't understand is that why using invalidate_inode_pages2() here. sync_blockdev() is just called and 0 is returned, I think in this case it's safe to call invalidate_bdev() directly, or am I missing other things? Thanks, Kuai > > Honza >
Powered by blists - more mailing lists