lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7a7df602-37b1-d134-ec51-7dba26f72213@huaweicloud.com> Date: Thu, 4 Jan 2024 14:50:18 +0800 From: Kemeng Shi <shikemeng@...weicloud.com> To: Ojaswin Mujoo <ojaswin@...ux.ibm.com> Cc: tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v2 2/9] ext4: remove unused parameter group in ext4_mb_choose_next_group_*() on 1/4/2024 1:57 PM, Ojaswin Mujoo wrote: > On Wed, Jan 03, 2024 at 06:28:14PM +0800, Kemeng Shi wrote: >> Remove unused parameter group in ext4_mb_choose_next_group_*(). > > Hey Kemeng, > > Just a small thing, the parameter we are removing is "ngroups" rather > than "group" so maybe fix that in the commit message. > > Other than that looks good, feel free to add > Thanks for let me know. I will fix it in next version. > Reviewed-by: Ojaswin Mujoo <ojaswin@...ux.ibm.com> >> >> Signed-off-by: Kemeng Shi <shikemeng@...weicloud.com> >> Reviewed-by: Jan Kara <jack@...e.cz> >> --- >> fs/ext4/mballoc.c | 12 ++++++------ >> 1 file changed, 6 insertions(+), 6 deletions(-) >> >> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c >> index 9f9b8dd06..765b62729 100644 >> --- a/fs/ext4/mballoc.c >> +++ b/fs/ext4/mballoc.c >> @@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp) >> * cr level needs an update. >> */ >> static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac, >> - enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups) >> + enum criteria *new_cr, ext4_group_t *group) >> { >
Powered by blists - more mailing lists