lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <a2c7910c-4c2f-4290-a895-1c4255b2ee62@linux.alibaba.com> Date: Fri, 5 Jan 2024 12:43:52 +0800 From: Gao Xiang <hsiangkao@...ux.alibaba.com> To: Yu Kuai <yukuai1@...weicloud.com>, Jan Kara <jack@...e.cz> Cc: axboe@...nel.dk, roger.pau@...rix.com, colyli@...e.de, kent.overstreet@...il.com, joern@...ybastard.org, miquel.raynal@...tlin.com, richard@....at, vigneshr@...com, sth@...ux.ibm.com, hoeppner@...ux.ibm.com, hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com, jejb@...ux.ibm.com, martin.petersen@...cle.com, clm@...com, josef@...icpanda.com, dsterba@...e.com, viro@...iv.linux.org.uk, brauner@...nel.org, nico@...xnic.net, xiang@...nel.org, chao@...nel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.com, konishi.ryusuke@...il.com, willy@...radead.org, akpm@...ux-foundation.org, hare@...e.de, p.raghav@...sung.com, linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, xen-devel@...ts.xenproject.org, linux-bcache@...r.kernel.org, linux-mtd@...ts.infradead.org, linux-s390@...r.kernel.org, linux-scsi@...r.kernel.org, linux-bcachefs@...r.kernel.org, linux-btrfs@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-erofs@...ts.ozlabs.org, linux-ext4@...r.kernel.org, linux-nilfs@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com, "yukuai (C)" <yukuai3@...wei.com> Subject: Re: [PATCH RFC v3 for-6.8/block 11/17] erofs: use bdev api On 2024/1/4 20:32, Yu Kuai wrote: > Hi, Jan! > > 在 2024/01/04 20:02, Jan Kara 写道: >> On Thu 21-12-23 16:58:26, Yu Kuai wrote: >>> From: Yu Kuai <yukuai3@...wei.com> >>> >>> Avoid to access bd_inode directly, prepare to remove bd_inode from >>> block_device. >>> >>> Signed-off-by: Yu Kuai <yukuai3@...wei.com> >> >> I'm not erofs maintainer but IMO this is quite ugly and grows erofs_buf >> unnecessarily. I'd rather store 'sb' pointer in erofs_buf and then do the >> right thing in erofs_bread() which is the only place that seems to care >> about the erofs_is_fscache_mode() distinction... Also blkszbits is then >> trivially sb->s_blocksize_bits so it would all seem much more >> straightforward. > > Thanks for your suggestion, I'll follow this unless Gao Xiang has other > suggestions. Yes, that would be better, I'm fine with that. Yet in the future we may support a seperate large dirblocksize more than block size, but we could revisit later. Thanks, Gao Xiang > > Kuai >> >> Honza >>
Powered by blists - more mailing lists