linux-ext4 - Re: [PATCH] fs/ext4: Allow for the last group to be marked as trimmed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170476879009.637731.2909208687184523548.b4-ty@mit.edu>
Date: Mon,  8 Jan 2024 21:53:21 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: Suraj Jitindar Singh <surajjs@...zon.com>
Cc: "Theodore Ts'o" <tytso@....edu>, adilger.kernel@...ger.ca, jack@...e.cz,
        linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        sjitindarsingh@...il.com, stable@...r.kernel.org
Subject: Re: [PATCH] fs/ext4: Allow for the last group to be marked as trimmed


On Wed, 13 Dec 2023 16:16:35 +1100, Suraj Jitindar Singh wrote:
> The ext4 filesystem tracks the trim status of blocks at the group level.
> When an entire group has been trimmed then it is marked as such and subsequent
> trim invocations with the same minimum trim size will not be attempted on that
> group unless it is marked as able to be trimmed again such as when a block is
> freed.
> 
> Currently the last group can't be marked as trimmed due to incorrect logic
> in ext4_last_grp_cluster(). ext4_last_grp_cluster() is supposed to return the
> zero based index of the last cluster in a group. This is then used by
> ext4_try_to_trim_range() to determine if the trim operation spans the entire
> group and as such if the trim status of the group should be recorded.
> 
> [...]

Applied, thanks!

[1/1] fs/ext4: Allow for the last group to be marked as trimmed
      commit: ddf2aa1bac7d9be3b8ba374c5bdb88da06e3e10f

Best regards,
-- 
Theodore Ts'o <tytso@....edu>