lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <1da0649d-812f-4dee-9c1b-af567afa2e46@p183> Date: Sat, 27 Jan 2024 12:44:09 +0300 From: Alexey Dobriyan <adobriyan@...il.com> To: Baokun Li <libaokun1@...wei.com> Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca, jack@...e.cz, ritesh.list@...il.com, linux-kernel@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com, chengzhihao1@...wei.com, yukuai3@...wei.com, libaokun1@...wei.com Subject: Re: [PATCH 1/7] ext4: avoid overflow when setting values via sysfs Baokun Li wrote: > @@ -463,6 +463,8 @@ static ssize_t ext4_attr_store(struct kobject *kobj, > ret = kstrtoul(skip_spaces(buf), 0, &t); > if (ret) > return ret; > + if (t != (unsigned int)t) > + return -EINVAL; kstrto*() interface has variants for all standard types. It should be changed to kstrtou32() or kstrtouint(); If you check if kstrto*() result fits into another type, you're probably doing it wrong. > if (a->attr_ptr == ptr_ext4_super_block_offset) > *((__le32 *) ptr) = cpu_to_le32(t);
Powered by blists - more mailing lists