lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240131002937.GB2020@sol.localdomain> Date: Tue, 30 Jan 2024 16:29:37 -0800 From: Eric Biggers <ebiggers@...nel.org> To: Gabriel Krisman Bertazi <krisman@...e.de> Cc: viro@...iv.linux.org.uk, jaegeuk@...nel.org, tytso@....edu, amir73il@...il.com, linux-ext4@...r.kernel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org Subject: Re: [PATCH v5 02/12] fscrypt: Factor out a helper to configure the lookup dentry On Mon, Jan 29, 2024 at 05:43:20PM -0300, Gabriel Krisman Bertazi wrote: > Both fscrypt_prepare_lookup_dentry_partial and > fscrypt_prepare_lookup_dentry will set DCACHE_NOKEY_NAME for dentries > when the key is not available. Shouldn't this say: "Both fscrypt_prepare_lookup() and fscrypt_prepare_lookup_partial() set DCACHE_NOKEY_NAME for dentries when the key is not available." > @@ -131,12 +128,13 @@ EXPORT_SYMBOL_GPL(__fscrypt_prepare_lookup); > int fscrypt_prepare_lookup_partial(struct inode *dir, struct dentry *dentry) > { > int err = fscrypt_get_encryption_info(dir, true); > + bool is_nokey_name = false; > + > + if (!err && !fscrypt_has_encryption_key(dir)) > + is_nokey_name = true; bool is_nokey_name = (err == 0 && !fscrypt_has_encryption_key(dir)); > diff --git a/include/linux/fscrypt.h b/include/linux/fscrypt.h > index 12f9e455d569..68ca8706483a 100644 > --- a/include/linux/fscrypt.h > +++ b/include/linux/fscrypt.h > @@ -948,6 +948,16 @@ static inline int fscrypt_prepare_rename(struct inode *old_dir, > return 0; > } > > +static inline void fscrypt_prepare_lookup_dentry(struct dentry *dentry, > + bool is_nokey_name) Maybe just fscrypt_prepare_dentry()? - Eric
Powered by blists - more mailing lists