lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202401311058.81kC2rCv-lkp@intel.com>
Date: Wed, 31 Jan 2024 11:14:51 +0800
From: kernel test robot <lkp@...el.com>
To: "Matthew Wilcox (Oracle)" <willy@...radead.org>,
	Christoph Hellwig <hch@....de>
Cc: oe-kbuild-all@...ts.linux.dev,
	"Matthew Wilcox (Oracle)" <willy@...radead.org>,
	linux-fsdevel@...r.kernel.org, linux-ext4@...r.kernel.org
Subject: Re: [PATCH 1/3] fs: Introduce buffered_write_operations

Hi Matthew,

kernel test robot noticed the following build warnings:

[auto build test WARNING on kleikamp-shaggy/jfs-next]
[also build test WARNING on akpm-mm/mm-everything linus/master v6.8-rc2 next-20240130]
[cannot apply to tytso-ext4/dev]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/fs-Introduce-buffered_write_operations/20240130-135555
base:   https://github.com/kleikamp/linux-shaggy jfs-next
patch link:    https://lore.kernel.org/r/20240130055414.2143959-2-willy%40infradead.org
patch subject: [PATCH 1/3] fs: Introduce buffered_write_operations
config: x86_64-allnoconfig (https://download.01.org/0day-ci/archive/20240131/202401311058.81kC2rCv-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240131/202401311058.81kC2rCv-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202401311058.81kC2rCv-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> mm/filemap.c:4060: warning: Function parameter or struct member 'ops' not described in 'filemap_write_iter'


vim +4060 mm/filemap.c

^1da177e4c3f41 Linus Torvalds          2005-04-16  4043  
e4dd9de3c66bc7 Jan Kara                2009-08-17  4044  /**
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4045)  * filemap_write_iter - write data to a file
e4dd9de3c66bc7 Jan Kara                2009-08-17  4046   * @iocb:	IO state structure
8174202b34c30e Al Viro                 2014-04-03  4047   * @from:	iov_iter with data to write
e4dd9de3c66bc7 Jan Kara                2009-08-17  4048   *
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4049)  * This is a wrapper around __filemap_write_iter() to be used by most
e4dd9de3c66bc7 Jan Kara                2009-08-17  4050   * filesystems. It takes care of syncing the file in case of O_SYNC file
9608703e488cf7 Jan Kara                2021-04-12  4051   * and acquires i_rwsem as needed.
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4052)  *
a862f68a8b3600 Mike Rapoport           2019-03-05  4053   * Return:
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4054)  * * negative error code if no data has been written at all or if
a862f68a8b3600 Mike Rapoport           2019-03-05  4055   *   vfs_fsync_range() failed for a synchronous write
a862f68a8b3600 Mike Rapoport           2019-03-05  4056   * * number of bytes written, even for truncated writes
e4dd9de3c66bc7 Jan Kara                2009-08-17  4057   */
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4058) ssize_t filemap_write_iter(struct kiocb *iocb, struct iov_iter *from,
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4059) 		const struct buffered_write_operations *ops)
^1da177e4c3f41 Linus Torvalds          2005-04-16 @4060  {
^1da177e4c3f41 Linus Torvalds          2005-04-16  4061  	struct file *file = iocb->ki_filp;
148f948ba877f4 Jan Kara                2009-08-17  4062  	struct inode *inode = file->f_mapping->host;
^1da177e4c3f41 Linus Torvalds          2005-04-16  4063  	ssize_t ret;
^1da177e4c3f41 Linus Torvalds          2005-04-16  4064  
5955102c9984fa Al Viro                 2016-01-22  4065  	inode_lock(inode);
3309dd04cbcd2c Al Viro                 2015-04-09  4066  	ret = generic_write_checks(iocb, from);
3309dd04cbcd2c Al Viro                 2015-04-09  4067  	if (ret > 0)
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4068) 		ret = __filemap_write_iter(iocb, from, ops);
5955102c9984fa Al Viro                 2016-01-22  4069  	inode_unlock(inode);
^1da177e4c3f41 Linus Torvalds          2005-04-16  4070  
e259221763a404 Christoph Hellwig       2016-04-07  4071  	if (ret > 0)
e259221763a404 Christoph Hellwig       2016-04-07  4072  		ret = generic_write_sync(iocb, ret);
^1da177e4c3f41 Linus Torvalds          2005-04-16  4073  	return ret;
^1da177e4c3f41 Linus Torvalds          2005-04-16  4074  }
21878deb477823 Matthew Wilcox (Oracle  2024-01-30  4075) 

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists