linux-ext4 - Re: [PATCH v2] ext4: Verify s_clusters_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <170861726754.823885.15911575133715045976.b4-ty@mit.edu>
Date: Thu, 22 Feb 2024 10:54:30 -0500
From: "Theodore Ts'o" <tytso@....edu>
To: Jan Kara <jack@...e.cz>
Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        Zhang Yi <yi.zhang@...wei.com>
Subject: Re: [PATCH v2] ext4: Verify s_clusters_per_group even without bigalloc


On Mon, 19 Feb 2024 18:10:33 +0100, Jan Kara wrote:
> Currently we ignore s_clusters_per_group field in the on-disk superblock
> if bigalloc feature is not enabled. However e2fsprogs don't even open
> the filesystem if s_clusters_per_group is invalid. This results in an
> odd state where kernel happily works with the filesystem while even
> e2fsck refuses to touch it. Verify that s_clusters_per_group is valid
> even if bigalloc feature is not enabled to make things consistent. Due
> to current e2fsprogs behavior it is unlikely there are filesystems out
> in the wild (except for intentionally fuzzed ones) with invalid
> s_clusters_per_group counts.
> 
> [...]

Applied, thanks!

[1/1] ext4: Verify s_clusters_per_group even without bigalloc
      commit: 1f85b452e07c370448fb4eb4472cd55fc6bf115c

Best regards,
-- 
Theodore Ts'o <tytso@....edu>