lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dd9abbd7-56af-4654-83ae-741d41493f5c@linux.dev>
Date: Mon, 26 Feb 2024 12:22:04 +0800
From: Chengming Zhou <chengming.zhou@...ux.dev>
To: tytso@....edu, adilger.kernel@...ger.ca
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, vbabka@...e.cz,
 roman.gushchin@...ux.dev, Xiongwei.Song@...driver.com
Subject: Re: [PATCH] ext4: remove SLAB_MEM_SPREAD flag usage

On 2024/2/24 21:48, chengming.zhou@...ux.dev wrote:
> From: Chengming Zhou <zhouchengming@...edance.com>
> 
> The SLAB_MEM_SPREAD flag is already a no-op as of 6.8-rc1, remove
> its usage so we can delete it from slab. No functional change.

Update changelog to make it clearer:

The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was
removed as of v6.8-rc1, so it became a dead flag since the commit
16a1d968358a ("mm/slab: remove mm/slab.c and slab_def.h"). And the
series[1] went on to mark it obsolete to avoid confusion for users.
Here we can just remove all its users, which has no functional change.

[1] https://lore.kernel.org/all/20240223-slab-cleanup-flags-v2-1-02f1753e8303@suse.cz/

Thanks!

> 
> Signed-off-by: Chengming Zhou <zhouchengming@...edance.com>
> ---
>  fs/ext4/super.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index eb689fb85ce9..9a744f22aa24 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1500,8 +1500,7 @@ static int __init init_inodecache(void)
>  {
>  	ext4_inode_cachep = kmem_cache_create_usercopy("ext4_inode_cache",
>  				sizeof(struct ext4_inode_info), 0,
> -				(SLAB_RECLAIM_ACCOUNT|SLAB_MEM_SPREAD|
> -					SLAB_ACCOUNT),
> +				SLAB_RECLAIM_ACCOUNT|SLAB_ACCOUNT,
>  				offsetof(struct ext4_inode_info, i_data),
>  				sizeof_field(struct ext4_inode_info, i_data),
>  				init_once);

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ