linux-ext4 - Re: [PATCH 0/3] fs_parser: handle parameters that can be empty and don't have a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8127e57f-51e8-437d-bf84-4836a315f696@sandeen.net>
Date: Fri, 1 Mar 2024 08:54:37 -0600
From: Eric Sandeen <sandeen@...deen.net>
To: Christian Brauner <brauner@...nel.org>,
 Luis Henriques <lhenriques@...e.de>
Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>,
 Alexander Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
 Miklos Szeredi <miklos@...redi.hu>, Amir Goldstein <amir73il@...il.com>,
 linux-ext4@...r.kernel.org, linux-fsdevel@...r.kernel.org,
 linux-unionfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/3] fs_parser: handle parameters that can be empty and
 don't have a value

On 3/1/24 7:12 AM, Christian Brauner wrote:
>> Unfortunately, the two filesystems that use this flag (ext4 and overlayfs)
>> aren't prepared to have the parameter value set to NULL.  Patches #2 and #3
>> fix this.
> 
> Both ext4 and overlayfs define
> 
> #define fsparam_string_empty(NAME, OPT) \
>         __fsparam(fs_param_is_string, NAME, OPT, fs_param_can_be_empty, NULL)
> 
> Please add that to include/linux/fs_parser.h so that it can be used by both.

The f2fs conversion will also need this, so yes, it'd be nice to hoist it out
of ext4 and overlayfs.

-Eric