linux-ext4 - Re: [PATCH] ext4: Remove unneeded if checks before kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <878r2w4n0k.fsf@doe.com>
Date: Tue, 05 Mar 2024 22:46:43 +0530
From: Ritesh Harjani (IBM) <ritesh.list@...il.com>
To: Thorsten Blum <thorsten.blum@...lux.com>, Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger.kernel@...ger.ca>
Cc: linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, Thorsten Blum <thorsten.blum@...lux.com>
Subject: Re: [PATCH] ext4: Remove unneeded if checks before kfree

Thorsten Blum <thorsten.blum@...lux.com> writes:

> kfree already checks if its argument is NULL. This fixes two
> Coccinelle/coccicheck warnings reported by ifnullfree.cocci.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  fs/ext4/super.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>

Sure. Thanks for your patch. 
Looks good to me. Feel free to add - 

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@...il.com>