linux-ext4 - [PATCH v2 0/3] fs_parser: handle parameters that can be empty and don't have a value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240307160225.23841-1-lhenriques@suse.de>
Date: Thu,  7 Mar 2024 16:02:22 +0000
From: Luis Henriques <lhenriques@...e.de>
To: Theodore Ts'o <tytso@....edu>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	Alexander Viro <viro@...iv.linux.org.uk>,
	Christian Brauner <brauner@...nel.org>,
	Jan Kara <jack@...e.cz>,
	Miklos Szeredi <miklos@...redi.hu>,
	Amir Goldstein <amir73il@...il.com>
Cc: linux-ext4@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	linux-unionfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Luis Henriques <lhenriques@...e.de>
Subject: [PATCH v2 0/3] fs_parser: handle parameters that can be empty and don't have a value

While investigating an ext4/053 fstest failure, I realised that there was
an issue when the flag 'fs_param_can_be_empty' is set in a parameter and it
doesn't have a value

After an initial attempt to fix the issue, Christian suggested a different
approach and the following patches are based in his suggestion.

Another change that I'm introducing in this v2 is the change of parameter
'test_dummy_encryption' to also use the new helper introduced by the first
patch in this series.

Finally, I'd like to ask someone to look closer at the overlayfs patch as
I don't think there were any fstests to validate the case where 'lowerdir'
is empty.

Luis Henriques (3):
  fs_parser: add helper to define parameters with string and flag types
  ext4: fix the parsing of empty string mount parameters
  ovl: fix the parsing of empty string mount parameters

 fs/ext4/super.c           | 25 ++++++++++---------------
 fs/overlayfs/params.c     | 13 +++++--------
 include/linux/fs_parser.h |  8 ++++++++
 3 files changed, 23 insertions(+), 23 deletions(-)