linux-ext4 - Re: [PATCH v2 9/9] ext4: clean up s_mb_rb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240314103635.fp2jab2ayfkph4td@quack3>
Date: Thu, 14 Mar 2024 11:36:35 +0100
From: Jan Kara <jack@...e.cz>
To: Baokun Li <libaokun1@...wei.com>
Cc: linux-ext4@...r.kernel.org, tytso@....edu, adilger.kernel@...ger.ca,
	jack@...e.cz, ritesh.list@...il.com, ojaswin@...ux.ibm.com,
	adobriyan@...il.com, linux-kernel@...r.kernel.org,
	yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH v2 9/9] ext4: clean up s_mb_rb_lock to fix build warnings
 with C=1

On Tue 27-02-24 17:11:48, Baokun Li wrote:
> Running sparse (make C=1) on mballoc.c we get the following warning:
> 
>  fs/ext4/mballoc.c:3194:13: warning: context imbalance in
>   'ext4_mb_seq_structs_summary_start' - wrong count at exit
> 
> This is because __acquires(&EXT4_SB(sb)->s_mb_rb_lock) was called in
> ext4_mb_seq_structs_summary_start(), but s_mb_rb_lock was removed in commit
> 83e80a6e3543 ("ext4: use buckets for cr 1 block scan instead of rbtree"),
> so remove the __acquires to silence the warning.
> 
> Signed-off-by: Baokun Li <libaokun1@...wei.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@...e.cz>

								Honza

> ---
>  fs/ext4/mballoc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 7ad089df2408..7ae8e04d6ef4 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -3192,7 +3192,6 @@ int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset)
>  }
>  
>  static void *ext4_mb_seq_structs_summary_start(struct seq_file *seq, loff_t *pos)
> -__acquires(&EXT4_SB(sb)->s_mb_rb_lock)
>  {
>  	struct super_block *sb = pde_data(file_inode(seq->file));
>  	unsigned long position;
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR