linux-ext4 - Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <3MDOTS1CN0V39.3MG49L9WIC8VM@mforney.org>
Date: Sun, 24 Mar 2024 17:22:50 -0700
From: Michael Forney <mforney@...rney.org>
To: Max Kellermann <max.kellermann@...os.com>
Cc: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org, brauner@...nel.org, stable@...r.kernel.org
Subject: Re: [PATCH] Revert "ext4: apply umask if ACL support is disabled"

Max Kellermann <max.kellermann@...os.com> wrote:
> This reverts commit 484fd6c1de13b336806a967908a927cc0356e312.  The
> commit caused a regression because now the umask was applied to
> symlinks and the fix is unnecessary because the umask/O_TMPFILE bug
> has been fixed somewhere else already.

Thanks, Max! I've verified that this fixes symlink modes for me,
as well as the flatpak corruption error I was getting.

> Fixes: https://lore.kernel.org/lkml/28DSITL9912E1.2LSZUVTGTO52Q@mforney.org/
> Signed-off-by: Max Kellermann <max.kellermann@...os.com>

Tested-by: Michael Forney <mforney@...rney.org>