lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20240402154842.508032-8-eugen.hristev@collabora.com> Date: Tue, 2 Apr 2024 18:48:40 +0300 From: Eugen Hristev <eugen.hristev@...labora.com> To: tytso@....edu, adilger.kernel@...ger.ca, linux-ext4@...r.kernel.org, jaegeuk@...nel.org, chao@...nel.org, linux-f2fs-devel@...ts.sourceforge.net, linux-fsdevel@...r.kernel.org Cc: linux-kernel@...r.kernel.org, kernel@...labora.com, eugen.hristev@...labora.com, viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz, krisman@...e.de Subject: [PATCH v15 7/9] f2fs: Log error when lookup of encoded dentry fails If the volume is in strict mode, generi c_ci_compare can report a broken encoding name. This will not trigger on a bad lookup, which is caught earlier, only if the actual disk name is bad. Suggested-by: Gabriel Krisman Bertazi <krisman@...e.de> Signed-off-by: Eugen Hristev <eugen.hristev@...labora.com> --- fs/f2fs/dir.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/fs/f2fs/dir.c b/fs/f2fs/dir.c index 88b0045d0c4f..64286d80dd30 100644 --- a/fs/f2fs/dir.c +++ b/fs/f2fs/dir.c @@ -192,11 +192,16 @@ static inline int f2fs_match_name(const struct inode *dir, struct fscrypt_name f; #if IS_ENABLED(CONFIG_UNICODE) - if (fname->cf_name.name) - return generic_ci_match(dir, fname->usr_fname, - &fname->cf_name, - de_name, de_name_len); - + if (fname->cf_name.name) { + int ret = generic_ci_match(dir, fname->usr_fname, + &fname->cf_name, + de_name, de_name_len); + if (ret == -EINVAL) + f2fs_warn(F2FS_SB(dir->i_sb), + "Directory contains filename that is invalid UTF-8"); + + return ret; + } #endif f.usr_fname = fname->usr_fname; f.disk_name = fname->disk_name; -- 2.34.1
Powered by blists - more mailing lists