linux-ext4 - [PATCH] jbd2: Add a comment for incorrect tag size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_1D453DB77B0F2091CB4A68568A77627D4E08@qq.com>
Date: Thu,  4 Apr 2024 21:36:54 +0800
From: Wang Jianjian <wangjianjian0@...mail.com>
To: linux-ext4@...r.kernel.org
Cc: Wang Jianjian <wangjianjian0@...mail.com>
Subject: [PATCH] jbd2: Add a comment for incorrect tag size

journal_tag_t has already counted the checksum size, however, for
compatibility reason, we don't fix this bug and keep it as is.

Signed-off-by: Wang Jianjian <wangjianjian0@...mail.com>
---
 fs/jbd2/journal.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index b6c114c11b97..b5e614818e8b 100644
--- a/fs/jbd2/journal.c
+++ b/fs/jbd2/journal.c
@@ -2698,6 +2698,10 @@ size_t journal_tag_bytes(journal_t *journal)
 
 	sz = sizeof(journal_block_tag_t);
 
+	/*
+	 * journal_block_tag_t has already counted checksum size
+	 * but for compatibility reason, we keep it as is.
+	 */
 	if (jbd2_has_feature_csum2(journal))
 		sz += sizeof(__u16);
 
-- 
2.34.3