linux-ext4 - Re: [PATCH] ext4: replace deprecated strncpy with alternatives

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171470889035.3010818.5490902997038029222.b4-ty@mit.edu>
Date: Fri,  3 May 2024 00:01:47 -0400
From: "Theodore Ts'o" <tytso@....edu>
To: Andreas Dilger <adilger.kernel@...ger.ca>,
        Justin Stitt <justinstitt@...gle.com>
Cc: "Theodore Ts'o" <tytso@....edu>, linux-ext4@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] ext4: replace deprecated strncpy with alternatives


On Thu, 21 Mar 2024 01:03:10 +0000, Justin Stitt wrote:
> strncpy() is deprecated for use on NUL-terminated destination strings
> [1] and as such we should prefer more robust and less ambiguous string
> interfaces.
> 
> in file.c:
> s_last_mounted is marked as __nonstring meaning it does not need to be
> NUL-terminated. Let's instead use strtomem_pad() to copy bytes from the
> string source to the byte array destination -- while also ensuring to
> pad with zeroes.
> 
> [...]

Applied, thanks!

[1/1] ext4: replace deprecated strncpy with alternatives
      commit: 744a56389f7398f286231e062c2e63f0de01bcc6

Best regards,
-- 
Theodore Ts'o <tytso@....edu>