linux-ext4 - Re: [PATCH] ext4: don't track ranges in fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47173a890acd8f92bcfa391263f86f73c2d37ec7.camel@decadent.org.uk>
Date: Wed, 19 Jun 2024 00:30:38 +0200
From: Ben Hutchings <ben@...adent.org.uk>
To: "Luis Henriques (SUSE)" <luis.henriques@...ux.dev>, Theodore Ts'o
	 <tytso@....edu>, Andreas Dilger <adilger@...ger.ca>
Cc: Harshad Shirwadkar <harshadshirwadkar@...il.com>, 
	linux-ext4@...r.kernel.org, 1039883@...s.debian.org
Subject: Re: [PATCH] ext4: don't track ranges in fast_commit if inode has
 inlined data

On Tue, 2024-06-18 at 15:43 +0100, Luis Henriques (SUSE) wrote:
> When fast-commit needs to track ranges, it has to handle inodes that have
> inlined data in a different way because ext4_fc_write_inode_data(), in the
> actual commit path, will attempt to map the required blocks for the range.
> However, inodes that have inlined data will have it's data stored in
> inode->i_block and, eventually, in the extended attribute space.
> 
> Unfortunately, because fast commit doesn't currently support extended
> attributes, the solution is to mark this commit as ineligible.
> 
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883
> Signed-off-by: Luis Henriques (SUSE) <luis.henriques@...ux.dev>

Reported-by: Hervé Werner <dud225@...mail.com>
Tested-by: Ben Hutchings <benh@...ian.org>

I think this should also have:

Fixes: 9725958bb75c ("ext4: fast commit may miss tracking unwritten range during ftruncate")

unless you think the problem is even older than that.

Ben.

> ---
>  fs/ext4/fast_commit.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/fs/ext4/fast_commit.c b/fs/ext4/fast_commit.c
> index 87c009e0c59a..d3a67bc06d10 100644
> --- a/fs/ext4/fast_commit.c
> +++ b/fs/ext4/fast_commit.c
> @@ -649,6 +649,12 @@ void ext4_fc_track_range(handle_t *handle, struct inode *inode, ext4_lblk_t star
>  	if (ext4_test_mount_flag(inode->i_sb, EXT4_MF_FC_INELIGIBLE))
>  		return;
>  
> +	if (ext4_has_inline_data(inode)) {
> +		ext4_fc_mark_ineligible(inode->i_sb, EXT4_FC_REASON_XATTR,
> +					handle);
> +		return;
> +	}
> +
>  	args.start = start;
>  	args.end = end;
>  

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)