linux-ext4 - Re: [PATCH] ext4: don't track ranges in fast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <142f06efb14253305ba407c034d400c36b2926de.camel@decadent.org.uk>
Date: Wed, 19 Jun 2024 15:47:06 +0200
From: Ben Hutchings <ben@...adent.org.uk>
To: Luis Henriques <luis.henriques@...ux.dev>
Cc: Theodore Ts'o <tytso@....edu>, Andreas Dilger <adilger@...ger.ca>, 
 Harshad Shirwadkar <harshadshirwadkar@...il.com>,
 linux-ext4@...r.kernel.org, 1039883@...s.debian.org
Subject: Re: [PATCH] ext4: don't track ranges in fast_commit if inode has
 inlined data

On Wed, 2024-06-19 at 08:58 +0100, Luis Henriques wrote:
> On Wed 19 Jun 2024 12:30:38 AM +02, Ben Hutchings wrote;
> 
> > On Tue, 2024-06-18 at 15:43 +0100, Luis Henriques (SUSE) wrote:
> > > When fast-commit needs to track ranges, it has to handle inodes that have
> > > inlined data in a different way because ext4_fc_write_inode_data(), in the
> > > actual commit path, will attempt to map the required blocks for the range.
> > > However, inodes that have inlined data will have it's data stored in
> > > inode->i_block and, eventually, in the extended attribute space.
> > > 
> > > Unfortunately, because fast commit doesn't currently support extended
> > > attributes, the solution is to mark this commit as ineligible.
> > > 
> > > Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1039883
> > > Signed-off-by: Luis Henriques (SUSE) <luis.henriques@...ux.dev>
> > 
> > Reported-by: Hervé Werner <dud225@...mail.com>
> > Tested-by: Ben Hutchings <benh@...ian.org>
> > 
> 
> Thanks a lot, Ben.
> 
> > I think this should also have:
> > 
> > Fixes: 9725958bb75c ("ext4: fast commit may miss tracking unwritten range during ftruncate")
> > 
> > unless you think the problem is even older than that.
> 
> If my understanding is correct (hopefully someone will confirm that!), I
> think the problem goes further back.  That commit just makes it more
> likely to be visible, but handling of inlined data is incorrect since the
> fast_commit merge.  So, I guess that's better to simply add:
> 
> Cc: stable@...r.kernel.org

That makes sense to me.

Ben.

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)