linux-ext4 - Re: [PATCH] ext4/059: disable block_validity checks when mounting a corrupted file system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240621163603.mid7acwta2tnbhqk@dell-per750-06-vm-08.rhts.eng.pek2.redhat.com>
Date: Sat, 22 Jun 2024 00:36:03 +0800
From: Zorro Lang <zlang@...nel.org>
To: Baokun Li <libaokun1@...wei.com>
Cc: Theodore Ts'o <tytso@....edu>,
	Ext4 Developers List <linux-ext4@...r.kernel.org>,
	linux-fstests@....edu,
	杨二坤 <yangerkun@...wei.com>,
	fstests@...r.kernel.org
Subject: Re: [PATCH] ext4/059: disable block_validity checks when mounting a
 corrupted file system

On Thu, Jun 13, 2024 at 10:09:44AM +0800, Baokun Li wrote:
> Hi Zorro,
> 
> Could you pick up this patch?
> This test case has been failing in the mainline for a while now.

Sorry I just noticed this patch, looks like it was not sent to fstests@.
Sure, I'll merge it, thanks for CC me :)

Thanks,
Zorro

> 
> Thanks,
> Baokun
> 
> On 2023/8/23 22:56, Theodore Ts'o wrote:
> > Kernels with the commit "ext4: add correct group descriptors and
> > reserved GDT blocks to system zone" will refuse to mount the corrupted
> > file system constructed by this test.  So in order to perform the
> > test, we need to disable the block_validity checks.
> > 
> > Signed-off-by: Theodore Ts'o <tytso@....edu>
> 
> Looks good to me, thanks for the patch!
> 
> Reviewed-and-tested-by: Baokun Li <libaokun1@...wei.com>
> 
> > ---
> >   tests/ext4/059 | 5 +++++
> >   1 file changed, 5 insertions(+)
> > 
> > diff --git a/tests/ext4/059 b/tests/ext4/059
> > index 4230bde92..e4af77f1e 100755
> > --- a/tests/ext4/059
> > +++ b/tests/ext4/059
> > @@ -31,6 +31,11 @@ $DEBUGFS_PROG -w -R "set_super_value s_reserved_gdt_blocks 100" $SCRATCH_DEV \
> >   $DEBUGFS_PROG -R "show_super_stats -h" $SCRATCH_DEV 2>/dev/null | \
> >   	grep "Reserved GDT blocks"
> > +# Kernels with the commit "ext4: add correct group descriptors and
> > +# reserved GDT blocks to system zone" will refuse to mount the file
> > +# system due to block_validity checks; so disable block_validity.
> > +MOUNT_OPTIONS="$MOUNT_OPTIONS -o noblock_validity"
> > +
> >   _scratch_mount
> >   # Expect no crash from this resize operation
> 
> 
> -- 
> With Best Regards,
> Baokun Li
>